Improvements to Makefile

[sabre1041]

Description

Improvements to Makefile to enable simplified building across multiple versions of make

Merge criteria:

• The commits and have meaningful messages; the author will squash them after approval or will ask to merge with squash.
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has manually tested the changes and verified that the changes work

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sabre1041
Once this PR has been reviewed and has the lgtm label, please assign isinyaaa for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

Hi @sabre1041. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tarilabs]

can someone on a linux box try this one out to confirm working on their end (non-Mac users) please?

thank you so much @sabre1041 ! 🚀

[rareddy]

what needs to be checked? I have linux box. I tried make build, I do not think below is anything to do with @sabre1041 PR but see below

$make build
/home/rareddy/development/model-registry/bin/openapi-generator-cli validate -i api/openapi/model-registry.yaml
Validating spec (api/openapi/model-registry.yaml)
No validation issues detected.
INFO api/openapi/model-registry.yaml is not staged or modified, will not re-generate server
/home/rareddy/development/model-registry/bin/goverter gen github.com/opendatahub-io/model-registry/internal/converter/
error parsing 'goverter:default' at
    /home/rareddy/development/model-registry/internal/converter/openapi_converter.go:68:2
    func (github.com/opendatahub-io/model-registry/internal/converter.OpenAPIConverter).OverrideNotEditableForDocArtifact(source github.com/opendatahub-io/model-registry/internal/converter.OpenapiUpdateWrapper[github.com/opendatahub-io/model-registry/pkg/openapi.DocArtifact]) (github.com/opendatahub-io/model-registry/pkg/openapi.DocArtifact, error)

unknown setting: default
make: *** [Makefile:62: internal/converter/generated/converter.go] Error 1

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d9144d9) 76.19% compared to head (fa14111) 76.19%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #314   +/-   ##
=======================================
  Coverage   76.19%   76.19%           
=======================================
  Files          17       17           
  Lines        2033     2033           
  Branches       74       74           
=======================================
  Hits         1549     1549           
  Misses        299      299           
  Partials      185      185           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[tarilabs]

Tested with:

GNU Make 4.4.1
Built for aarch64-apple-darwin22.3.0
Copyright (C) 1988-2023 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <https://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

GNU Make 3.81
Copyright (C) 2006  Free Software Foundation, Inc.
This is free software; see the source for copying conditions.
There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A
PARTICULAR PURPOSE.

This program built for i386-apple-darwin11.3.0

[tarilabs]

Also tested with:

GNU Make 4.4.1
Built for x86_64-redhat-linux-gnu
Copyright (C) 1988-2023 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <https://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

on:

Linux fedora 6.6.14-200.fc39.x86_64 #1 SMP PREEMPT_DYNAMIC Fri Jan 26 20:12:16 UTC 2024 x86_64 GNU/Linux

/lgtm