GHA: fetch tags on Python release checkout action #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dtrifiro do you think this should work or would you rather go with FYI I'm basing myself on https://github.com/actions/checkout/blob/main/README.md?plain=1#L93. |
tarilabs
previously approved these changes
Dec 13, 2023
|
I think it would be ok. What about explicitly using: on:
release:
types: [published]and explicitly creating the release (and release notes) on github? |
Signed-off-by: Isabella Basso do Amaral <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #244 +/- ##
=======================================
Coverage 74.52% 74.52%
=======================================
Files 17 17
Lines 2296 2296
Branches 73 73
=======================================
Hits 1711 1711
Misses 420 420
Partials 165 165 ☔ View full report in Codecov by Sentry. |
|
Updated and tested on: https://github.com/isinyaaa/model-registry/actions/runs/7197484144/job/19604711876 |
tarilabs
approved these changes
Dec 13, 2023
dhirajsb
pushed a commit
to dhirajsb/model-registry
that referenced
this pull request
Jan 20, 2025
… to 0.2.4-alpha in /clients/ui/bff (opendatahub-io#244) Bumps [github.com/kubeflow/model-registry](https://github.com/kubeflow/model-registry) from 0.2.3-alpha to 0.2.4-alpha. - [Release notes](https://github.com/kubeflow/model-registry/releases) - [Commits](kubeflow/model-registry@v0.2.3-alpha...v0.2.4-alpha) --- updated-dependencies: - dependency-name: github.com/kubeflow/model-registry dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fetch tags when checking out the repo on the Python release workflow.
How Has This Been Tested?
Tested on: https://github.com/isinyaaa/model-registry/actions/runs/7197484144/job/19604711876.
Merge criteria: