Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change state to desiredState for InferenceService #243

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Change state to desiredState for InferenceService #243

merged 1 commit into from
Dec 15, 2023

Conversation

lampajr
Copy link
Contributor

@lampajr lampajr commented Dec 13, 2023

Fixes https://github.com/opendatahub-io/model-registry/issues/229

Description

As the state property in InferenceService is an "intention", set by user, to do something we decided to change the property name from state to desiredState

  • Change in openapi specification
  • Change in core and mlmd type property

Change in python client is not needed as Serving interaction are not implemented there yet

NOTE: since there is NOT a release yet I renamed the property in mlmd, keep in mind that if you have some DBs running with the old schema you might have to delete it and recreate as MLMD does not accept to rename properties. Maybe this is something we could take into account later, i.e, trying to be resilient to schema changes (or just be everytime backward compatible)

How Has This Been Tested?

Go tests

make test

Merge criteria:

  • The commits and have meaningful messages; the author will squash them after approval or will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7b351c2) 74.52% compared to head (0977753) 74.72%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #243      +/-   ##
==========================================
+ Coverage   74.52%   74.72%   +0.20%     
==========================================
  Files          17       17              
  Lines        2296     2287       -9     
  Branches       73       73              
==========================================
- Hits         1711     1709       -2     
+ Misses        420      414       -6     
+ Partials      165      164       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lampajr lampajr marked this pull request as ready for review December 13, 2023 18:58
@lampajr

This comment was marked as outdated.

@lampajr lampajr requested a review from a team December 14, 2023 07:46
@lampajr lampajr merged commit 51b45f1 into opendatahub-io:main Dec 15, 2023
7 checks passed
@lampajr lampajr deleted the lampajr_20231213_gh229_inference_state branch December 15, 2023 15:36
dhirajsb pushed a commit to dhirajsb/model-registry that referenced this pull request Jan 20, 2025
…endatahub-io#243)

Bumps [ruff](https://github.com/astral-sh/ruff) from 0.5.5 to 0.5.6.
- [Release notes](https://github.com/astral-sh/ruff/releases)
- [Changelog](https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md)
- [Commits](astral-sh/ruff@0.5.5...0.5.6)

---
updated-dependencies:
- dependency-name: ruff
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InferenceService state terminology
3 participants