OSSM: Add SM overlays to notebook-controller manifests #184
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds Service Mesh overlays to the two notebook controller manifests. This is needed as v2 operator pulls manifests from kubeflow:v1.7 branch rather than from odh-manifests as it previously did.
The overlays changes are very minimal - in kf-notebook-controller, the service mesh overlay patches the configmap to ensure USE_ISTIO=true, and that the default gateway is
opendatahub/odh-gateway
. In odh-notebook-controller, the only patch is to the image to use our latest maistra build - once PR #172 is merged, we can safely remove this overlay.Since the changes in this PR are contained to service-mesh overlays, these changes should not interfere with non-service mesh deployments.
How Has This Been Tested?
To test and ensure that the overlays work as intended, ran commands:
kustomize build components/odh-notebook-controller/config/overlays/service-mesh
kustomize build components/notebook-controller/config/overlays/service-mesh
to ensure that
A: kustomize can build the overlay without errors
B: patches are applied correctly.
Merge criteria: