Skip to content

Commit

Permalink
Remove the -generated to oauth-client volume name
Browse files Browse the repository at this point in the history
  • Loading branch information
daniellutz committed Nov 14, 2024
1 parent 009b144 commit 8e285fd
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -648,7 +648,7 @@ var _ = Describe("The Openshift Notebook controller", func() {
Name: "oauth-client",
VolumeSource: corev1.VolumeSource{
Secret: &corev1.SecretVolumeSource{
SecretName: Name + "-oauth-client-generated",
SecretName: Name + "-oauth-client",
DefaultMode: pointer.Int32Ptr(420),
},
},

Check failure on line 654 in components/odh-notebook-controller/controllers/notebook_controller_test.go

View workflow job for this annotation

GitHub Actions / golangci-lint (components/odh-notebook-controller)

SA1019: pointer.Int32Ptr is deprecated: Use ptr.To instead. (staticcheck)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ func InjectOAuthProxy(notebook *nbv1.Notebook, oauth OAuthConfig) error {
Name: "oauth-client",
VolumeSource: corev1.VolumeSource{
Secret: &corev1.SecretVolumeSource{
SecretName: notebook.Name + "-oauth-client-generated",
SecretName: notebook.Name + "-oauth-client",
DefaultMode: pointer.Int32Ptr(420),

Check failure on line 218 in components/odh-notebook-controller/controllers/notebook_webhook.go

View workflow job for this annotation

GitHub Actions / golangci-lint (components/odh-notebook-controller)

SA1019: pointer.Int32Ptr is deprecated: Use ptr.To instead. (staticcheck)
},
},
Expand Down

0 comments on commit 8e285fd

Please sign in to comment.