Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPSTREAM: <carry>: Rebase code to kfp 2.2.0 #78

Merged
merged 231 commits into from
Oct 8, 2024

Conversation

rimolive
Copy link

Description of your changes:

Checklist:

TheMichaelHu and others added 30 commits December 14, 2023 14:25
PiperOrigin-RevId: 591075392
* add subprocess task handler

* response to review feedback
…` when uploading models from `preview.llm.rlhf_pipeline` instead of hardcoding value as `text-bison@001`

PiperOrigin-RevId: 591346782
…lm.rlhf_pipeline` run instead of reusing cached result

PiperOrigin-RevId: 591365087
…f model checkpoint from `preview.llm.rlhf_pipeline`

PiperOrigin-RevId: 591393116
…eflow#10325)

* feat(sdk): add local execution output collection #localexecution

* update ExecutorInput processing

* address review feedback

* fix exception handling test
PiperOrigin-RevId: 592033936
…10318) (kubeflow#10319)

* feat: preserve querystring in pipeline root

* refactor: create AppendToPipelineRoot
Also apply to client.go

* feat: remove query string from URIs (#1)

* feat: remove query string from URIs

* refactor(GenerateOutputURI): move and preserve comments
kubeflow#10333)

* support Container Components

* address review feedback
PiperOrigin-RevId: 592702825
…r component execution #localexecution (kubeflow#10348)

* feat(sdk): support Concat and IfPresent placeholder in local container component execution #localexecution

* address review feedback

* fix test
@dsp-developers
Copy link

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting
commitchecker verson unknown
Validating 0 commits between 0f96e42b1bd0968e898f6912a7b23f0a1285c6db...b9c7a42a34a491573135add13f875154e6feb540

@dsp-developers
Copy link

Change to PR detected. A new PR build was completed.
A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-78
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-78
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-78
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-78
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-78
MLMD Server: quay.io/opendatahub/mlmd-grpc-server:latest
MLMD Envoy Proxy: registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-78

@dsp-developers
Copy link

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting
commitchecker verson unknown
Validating 0 commits between 0f96e42b1bd0968e898f6912a7b23f0a1285c6db...8e291dac97ee7e77c1f8ff3e7ec4e64d9c9742ce

@dsp-developers
Copy link

Change to PR detected. A new PR build was completed.
A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-78
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-78
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-78
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-78
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-78
MLMD Server: quay.io/opendatahub/mlmd-grpc-server:latest
MLMD Envoy Proxy: registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-78

@dsp-developers
Copy link

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting
commitchecker verson unknown
Validating 0 commits between 0f96e42b1bd0968e898f6912a7b23f0a1285c6db...fa2ed8e1d6a74d0386a98bdf4ab76a9f1bcf86ad

@dsp-developers
Copy link

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting
commitchecker verson unknown
Validating 0 commits between 0f96e42b1bd0968e898f6912a7b23f0a1285c6db...a99d754d3ea4428b37693363e3cfa639ec709406

@dsp-developers
Copy link

Change to PR detected. A new PR build was completed.
A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-78
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-78
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-78
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-78
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-78
MLMD Server: quay.io/opendatahub/mlmd-grpc-server:latest
MLMD Envoy Proxy: registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-78

Copy link

openshift-ci bot commented Oct 8, 2024

The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the opendatahub-io org. You can then trigger verification by writing /verify-owners in a comment.

  • Tomcli
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
    • backend/OWNERS

@dsp-developers
Copy link

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting
commitchecker verson unknown
Validating 0 commits between 0f96e42b1bd0968e898f6912a7b23f0a1285c6db...5b9caa3e954ea41c961e944aecf7dc797ed99250

@dsp-developers
Copy link

Change to PR detected. A new PR build was completed.
A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-78
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-78
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-78
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-78
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-78
MLMD Server: quay.io/opendatahub/mlmd-grpc-server:latest
MLMD Envoy Proxy: registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-78

1 similar comment
@dsp-developers
Copy link

Change to PR detected. A new PR build was completed.
A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-78
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-78
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-78
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-78
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-78
MLMD Server: quay.io/opendatahub/mlmd-grpc-server:latest
MLMD Envoy Proxy: registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-78

@HumairAK
Copy link

HumairAK commented Oct 8, 2024

/lgtm
/approve

Copy link

openshift-ci bot commented Oct 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Oct 8, 2024
@HumairAK HumairAK merged commit 028d903 into opendatahub-io:master Oct 8, 2024
4 of 5 checks passed
@dsp-developers
Copy link

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting
commitchecker verson unknown
Validating 0 commits between 028d903889f2de5d7e0ac27be001f9523a3a126e...5b9caa3e954ea41c961e944aecf7dc797ed99250

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.