odc.stac.load - ValueError if Asset name contains dot (file extension)

[clausmichele]

MWE to reproduce the issue:

import odc.stac
import pystac

item = pystac.read_file("https://gist.githubusercontent.com/clausmichele/921fd2551cbf0c586799eeaa3d42876f/raw/835f887c8e50bd3d05c43ab31defad0aa1e975c8/ogct20_gee_add_tranform.json")
odc.stac.load([item])

Error:
ValueError: invalid literal for int() with base 10: 'tiff'

The problem is here:
https://github.com/opendatacube/odc-stac/blob/develop/odc/loader/types.py#L589

since it's trying to cast to int the string tiff

[Kirill888]

@clausmichele thanks for the report, this is now fixed on develop branch. Some comments about the stac document linked above

This part:

      "eo:bands": [
        {
          "name": "tmmx"
        }
      ],

is not being parsed out, should be "common_name": "tmmx", and also eo extension is not listed in stac_extensions.

I'd recommend naming asset tmmx in this case, since you clearly know what the "band name" is, rather than using file name as an asset name.

[clausmichele]

Thanks @Kirill888 for the quick fix

[m-mohr]

@Kirill888 Thank you. Please note that a common name tmmx is invalid according to STAC. I'll add the EO extension, thanks for noting this.

[Kirill888]

@m-mohr I see, it's a fixed set of names. And is "eo:bands": {"name: "ArbiTraRy_nAme"} part of eo extension?

[m-mohr]

Yes, although with STAC 1.1 that has slightly changed to "bands": {"name": "ArbiTraRy_nAme"} in core. @Kirill888