-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update windows setup instructions #1526
Conversation
* Github action fixes, backported from develop-1.9 * Updates to whats_new.rst * Capitalise "Dependabot" in whats_new.rst
We used to deploy to netlify for docs previews, but now that's done to Read The Docs. The old Workflow should be removed.
updates: - [github.com/adrienverge/yamllint.git: v1.30.0 → v1.31.0](https://github.com/adrienverge/yamllint.git/compare/v1.30.0...v1.31.0)
for more information, see https://pre-commit.ci
Error message for missing arguments
add license hook to pre-commit
Allow open date range in dataset search
* support open ended date range in query init * allow open ended time ranges in load() and find_datasets(), also simplify logic for cli * update doco and whats_new * get end of datetime.now() to avoid failing tests due to second mismatches * Minor update to documentation Even with open bounds, dates are still inclusive of the start and end dates. Minor update to wording to make this clearer --------- Co-authored-by: Ariana Barzinpour <[email protected]> Co-authored-by: Robbi Bishop-Taylor <[email protected]>
updates: - [github.com/adrienverge/yamllint.git: v1.31.0 → v1.32.0](https://github.com/adrienverge/yamllint.git/compare/v1.31.0...v1.32.0)
* Pass X and Y Scale factors through to rasterio.warp.project. Update whats_new * Update PR number in whats_new.rst * Remove unused import. * Cleanup. * Cleanup. * Should probably just add it to the dictionary tbh. * Respond to Kirill's comments.
add archive_less_mature option to add and update
Better archiving error
* don't archive less mature if value is False instead of None * update whats_new * update delta typehint, improve type/value validation * add warning message if delta is bool * fix type check * add test for not archiving less mature, fix find less mature type check * fix logic for real this time --------- Authored-by: Ariana Barzinpour <[email protected]>
* Require Python >=3.9 Add tags for Py 3.10 and 3.11. * Remove conda tests for 3.8. Add for 3.10 and 3.11. * Updated Whats new.rst * Bump lint.yaml GHA to Py3.9 * Updated PR number * Require Python >=3.9 Add tags for Py 3.10 and 3.11. * Remove conda tests for 3.8. Add for 3.10 and 3.11. * Updated Whats new.rst * Bump lint.yaml GHA to Py3.9 * Updated PR number
* Update whats_new.rst with release notes. * Manually apply recent dependabot upgrades. * Removed some lingering references to Python3.8+ (including conda-environment.yml)
* Suppress SQLAlchemy warnings. * Fixed spelling mistake in whats_new and fixed drop schema where no schema does not exist. * Switch to jsonschema 4.18+ "references" API. * Rebase onto develop. * Add repin (as in pin again) to the dictionary. * Ugh - could have sworn this was working on Friday.
updates: - [github.com/adrienverge/yamllint.git: v1.32.0 → v1.33.0](https://github.com/adrienverge/yamllint.git/compare/v1.32.0...v1.33.0)
Bumps [conda-incubator/setup-miniconda](https://github.com/conda-incubator/setup-miniconda) from 2 to 3. - [Release notes](https://github.com/conda-incubator/setup-miniconda/releases) - [Changelog](https://github.com/conda-incubator/setup-miniconda/blob/main/CHANGELOG.md) - [Commits](conda-incubator/setup-miniconda@v2...v3) --- updated-dependencies: - dependency-name: conda-incubator/setup-miniconda dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
* add dataset cli tool to find duplicates * convert timestamps to UTC * update whats_new * update memory driver search duplicates implementation --------- Co-authored-by: Ariana Barzinpour <[email protected]>
* warn if non-eo3 dataset has eo3 metadata type * fix str contains * add test --------- Co-authored-by: Ariana Barzinpour <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1526 +/- ##
===========================================
- Coverage 91.84% 91.79% -0.05%
===========================================
Files 132 132
Lines 14466 14624 +158
===========================================
+ Hits 13286 13424 +138
- Misses 1180 1200 +20 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should be telling them to git clone or run the integration tests here.
Just tell them the bare minimum they need to get a conda environment working on windows - with datacube coming from PIP or Condaforge.
22cced7
to
39c96e8
Compare
Reason for this pull request
Windows developer setup instructions are out of date and incomplete.
Proposed changes
Update windows setup guide to be more complete
Closes #xxxx
Tests added / passed
Fully documented, including
docs/about/whats_new.rst
for all changes📚 Documentation preview 📚: https://datacube-core--1526.org.readthedocs.build/en/1526/