Backport fixes from odc-geo #1242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Non-axis aligned geoboxes are supported actually, only coordinate computation assumes axis-aligned geobox. So move assert into there.
Codecov Report
@@ Coverage Diff @@
## develop #1242 +/- ##
===========================================
- Coverage 93.86% 93.86% -0.01%
===========================================
Files 109 109
Lines 10760 10772 +12
===========================================
+ Hits 10100 10111 +11
- Misses 660 661 +1
Continue to review full report at Codecov.
|
uchchwhash
approved these changes
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this pull request
performance and correctness fixes back ported from
odc-geo.Proposed changes
changes constructor and hashing of the CRS class (related: Non-EPSG WKT projections are slower to create than standard EPSG projections #1222 load_ard() task graph creation limited by GeoBox/CRS hash function performance #1230), note that I could not just fix hashing without also ensuring that string representation is consistent across equivalent CRS objects which constructor changes achieve.
removes overly strict assert in GeoBox, axis-aligned constraint only applies for coordinate computation code
Closes load_ard() task graph creation limited by GeoBox/CRS hash function performance #1230
Tests added / passed
Fully documented, including
docs/about/whats_new.rstfor all changes