This repository has been archived by the owner on Jan 24, 2022. It is now read-only.
WIP: get expected date of next pkg-update #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefina
force-pushed
the
OGD-640_expected-update
branch
2 times, most recently
from
408c798 to
7e859c5
Compare
stefina
changed the title
|
TODO:
|
metaodi
suggested changes
Aug 23, 2017
| 'http://purl.org/cld/freq/annual': timedelta(days=365), # noqa | ||
| 'http://purl.org/cld/freq/biennial': timedelta(days=730), # noqa | ||
| 'http://purl.org/cld/freq/triennial': timedelta(days=1095), # noqa | ||
| } |
There was a problem hiding this comment.
If you don't need this, get rid of it ;)
| self.assertEquals(None, helpers.get_expected_update(modified_set, period_irregular)) #noqa | ||
| self.assertEquals(None, helpers.get_expected_update(modified_set, period_continuous)) #noqa | ||
| self.assertEquals(None, helpers.get_expected_update(modified_set, period_empty)) #noqa | ||
| self.assertEquals(None, helpers.get_expected_update(modified_set, period_invalid)) #noqa |
There was a problem hiding this comment.
If you test for None, you should use assertIsNone
| 'http://purl.org/cld/freq/semiannual': timedelta(days=183), # noqa | ||
| 'http://purl.org/cld/freq/annual': timedelta(days=365), # noqa | ||
| 'http://purl.org/cld/freq/biennial': timedelta(days=730), # noqa | ||
| 'http://purl.org/cld/freq/triennial': timedelta(days=1095), # noqa |
There was a problem hiding this comment.
I quickly looked for alternatives to timedelta and found dateutil.relativedelta, which offers a more precise solution to our problem. E.g. the monthly delta is now set to 30 days, while we actually want 1 month (ranging from 28-31 days). Maybe check this example: https://stackoverflow.com/questions/546321/how-do-i-calculate-the-date-six-months-from-the-current-date-using-the-datetime/4406260#4406260
stefina
force-pushed
the
OGD-640_expected-update
branch
2 times, most recently
from
91469db to
bd9c830
Compare
stefina
force-pushed
the
OGD-640_expected-update
branch
from
bd9c830 to
5b1376f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.