-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] tools-v2: add scan-state #2465
Conversation
595ea78
to
c581f66
Compare
c821747
to
9fdc9e5
Compare
config.AddRpcTimeoutFlag(sCmd.Cmd) | ||
|
||
config.AddBSLogicalPoolIdRequiredFlag(sCmd.Cmd) | ||
config.AddBsScanOptionFlag(sCmd.Cmd) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flag scan is required, will it be better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my opinion, from the user's point of view, it is more intuitive for the scan flag to default to true. At the same time, reducing parameters can reduce the user's memory burden.
tools-v2/pkg/cli/command/curvebs/update/scan_state/scan_state.go
Outdated
Show resolved
Hide resolved
tools-v2/pkg/cli/command/curvebs/update/scan_state/scan_state.go
Outdated
Show resolved
Hide resolved
9fdc9e5
to
0af2dd1
Compare
cicheck |
Please merge your commits into one |
Signed-off-by: montaguelhz <[email protected]>
3c8b793
to
ced50f9
Compare
cicheck |
What problem does this PR solve?
Issue Number: #2360
Problem Summary:
support bs set scan command in [curve tool]
What is changed and how it works?
What's Changed:
How it Works:
command result
Side effects(Breaking backward compatibility? Performance regression?):
Check List