-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] tools-v2: add do-snapshot #2454
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cicheck |
Xinlong-Chen
force-pushed
the
do-snapshot-2
branch
from
May 6, 2023 14:31
f1f43f2
to
a17eda8
Compare
cicheck |
Xinlong-Chen
force-pushed
the
do-snapshot-2
branch
5 times, most recently
from
May 7, 2023 03:29
057de9b
to
70f483c
Compare
cicheck |
1 similar comment
cicheck |
|
Xinlong-Chen
force-pushed
the
do-snapshot-2
branch
2 times, most recently
from
May 10, 2023 10:14
2bb9918
to
99d7260
Compare
cicheck |
Xinlong-Chen
force-pushed
the
do-snapshot-2
branch
2 times, most recently
from
May 10, 2023 12:22
492fd11
to
2cdcd36
Compare
cicheck |
Signed-off-by: Xinlong-Chen <[email protected]>
Xinlong-Chen
force-pushed
the
do-snapshot-2
branch
from
May 10, 2023 12:32
2cdcd36
to
6fc32ec
Compare
Cyber-SiKu
approved these changes
May 10, 2023
wu-hanqing
approved these changes
May 10, 2023
cicheck |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: #2023
Problem Summary: add command
curve bs snapshot one
What is changed and how it works?
What's Changed:
tools-v2/pkg/cli/command/curvebs/snapshot/snapshot.go
tools-v2/pkg/cli/command/curvebs/snapshot/one/one.go
tools-v2/pkg/cli/command/curvebs/bs.go
How it Works:
implement by using rpc
snapshot
Side effects(Breaking backward compatibility? Performance regression?):
Check List