Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] tools-v2: add client-status #2446

Merged
merged 1 commit into from
May 6, 2023
Merged

[feat] tools-v2: add client-status #2446

merged 1 commit into from
May 6, 2023

Conversation

Xinlong-Chen
Copy link
Contributor

@Xinlong-Chen Xinlong-Chen commented Apr 27, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: #2345

Problem Summary: add client-status in tools-v2

What is changed and how it works?

What's Changed:

  1. command curve bs list client, modify return result to make it correct.
  2. add command curve bs status client in (tools-v2/pkg/cli/command/curvebs/status/client)

How it Works:
just a client command. reuse command curve bs list client, and get status from client list.

the result in tools-v1:

Client status: 
nebd-server: version-9.9.9+2c4861ca: 2

the result in tools-v2:

+-------------+----------------+---------------------+-----+
|    TYPE     |    VERSION     |        ADDR         | NUM |
+-------------+----------------+---------------------+-----+
| nebd-server | 9.9.9+2c4861ca | 192.168.20.149:9001 | 2   |
+             +                +---------------------+     +
|             |                | 192.168.20.149:9002 |     |
+-------------+----------------+---------------------+-----+

Side effects(Breaking backward compatibility? Performance regression?):
core logic is not affected, because it just a client command.

Check List

  • Relevant documentation/comments is changed or added
  • I acknowledge that all my contributions will be made under the project's license

@Xinlong-Chen
Copy link
Contributor Author

cicheck

@Xinlong-Chen
Copy link
Contributor Author

Anyone else to cr this pr?

@Xinlong-Chen
Copy link
Contributor Author

cicheck

@Xinlong-Chen Xinlong-Chen force-pushed the client-status branch 3 times, most recently from 7b685f8 to 39b2779 Compare April 29, 2023 06:39
@Xinlong-Chen
Copy link
Contributor Author

recheck

Cyber-SiKu
Cyber-SiKu reviewed May 4, 2023
View reviewed changes
tools-v2/README.md Outdated Show resolved Hide resolved
tools-v2/pkg/cli/command/curvebs/status/client/client.go Outdated Show resolved Hide resolved
tools-v2/pkg/cli/command/curvebs/status/client/client.go Outdated Show resolved Hide resolved
@Xinlong-Chen
Copy link
Contributor Author

cicheck

@Xinlong-Chen
Copy link
Contributor Author

@Cyber-SiKu here, please have a look again...

@Xinlong-Chen
Copy link
Contributor Author

cicheck

@Xinlong-Chen
Copy link
Contributor Author

cicheck

@Cyber-SiKu Cyber-SiKu merged commit 93830aa into opencurve:master May 6, 2023
@Xinlong-Chen Xinlong-Chen deleted the client-status branch May 10, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cyber-SiKu Cyber-SiKu Cyber-SiKu approved these changes

@wu-hanqing wu-hanqing wu-hanqing approved these changes

Assignees
No one assigned
Labels
Developer Activities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Xinlong-Chen @wu-hanqing @Cyber-SiKu @zhanghuidinah