Fix project build, fix for tse.csv #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t Id refers to the custom vat id hence need not be validated ) - The TSE_TA_SIG and TSE_TA_SIGZ should have alphanumeric data type - Add the required properties in the class StammTse and also check for the field lengths and field types
dhaeb
commented
Mar 29, 2021
| @@ -19,7 +19,7 @@ | |||
| public static final String FILENAME = "transactions_vat.csv"; | |||
|
|
|||
| @NotNull | |||
| @ValidVatId | |||
| // @ValidVatId | |||
There was a problem hiding this comment.
Needed to comment out due to wrong validation results.
|
Hi @dhaeb, sorry for the slow response due to the holidays. I'll get back to you as soon as possible (this week hopefully) and we can sort something out |
|
I'm happy to just remove the module-info.java in its entirety. I actually thought I already did so but it might just have been the gdpu project where I did so. I'm also happy to merge as is. I'll leave it up to you. Regarding the "future": Do you want to have a call? If you're interested ping me at lars.francke at opencore.com |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
as I stated in #22, my company is interested in maintaining the project. To get it building using java 11+, I needed to adjust the module_info.java file. To be able to run it from command line, I added the assembly plugin to build a "fat jar".
Additionally, we tried the current state with our csv files and noticed that the tse.csv "binding" were not in place. So we created our own, currently using strings instead of the given enums for pragmatic ease of use.
If you have questions , just ask. I would also be interested in getting access to the repo in general, as we plan to use the tool in our CI chain and opt in for future development.
Best,
Dan