lint: fix warnings from whitespace and gocritic, enable those #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found by whitespace linter: > go-selinux/label/label_selinux.go:60: unnecessary trailing newline (whitespace) > > go-selinux/label/label_selinux_test.go:160: unnecessary trailing newline (whitespace) > > go-selinux/selinux_linux_test.go:51: unnecessary trailing newline (whitespace) Fix these, enable the linter. Signed-off-by: Kir Kolyshkin <[email protected]>
The warnings were:
```
go-selinux/label/label_selinux.go:30:66: captLocal: `Err' should not be capitalized (gocritic)
func InitLabels(options []string) (plabel string, mlabel string, Err error) {
^
go-selinux/selinux_linux.go:831:3: assignOp: replace `ORD = ORD - TIER` with `ORD -= TIER` (gocritic)
ORD = ORD - TIER
^
go-selinux/selinux_linux.go:835:2: assignOp: replace `ORD = ORD + TIER` with `ORD += TIER` (gocritic)
ORD = ORD + TIER
^
go-selinux/selinux_linux.go:853:10: elseif: can replace 'else {if cond {}}' with 'else if cond {}' (gocritic)
} else {
^
```
Signed-off-by: Kir Kolyshkin <[email protected]>
kolyshkin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Vertical whitespace nits.
Found by whitespace linter:
Fix these, enable the linter.
2. Fix gocritic warnings, enable the linter
The warnings were: