-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runtimetest: add root filesystem validation #78
runtimetest: add root filesystem validation #78
Conversation
Hi @Mashimiao I just submitted a PR #81 which does the same thing, but by using mount information. I think it might be wrong to verify the
|
On Thu, May 26, 2016 at 03:43:54AM -0700, 梁辰晔 (Liang Chenye) wrote:
Ah, good point. We should definitely be testing read-only by |
faf90f0
to
e78cae6
Compare
@liangchenye @wking re-implemented with pre-write |
On Thu, May 26, 2016 at 09:47:37PM -0700, Ma Shimiao wrote:
I'll leave it to you and @liangchenye to decide whether this rerolled |
} | ||
|
||
tmpfile.Close() | ||
os.RemoveAll(filepath.Join(path,tmpfile.Name())) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably needs gofmt run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mrunalp Ah, sorry. fixed.
Signed-off-by: Ma Shimiao <[email protected]>
e78cae6
to
d9b2746
Compare
LGTM |
Signed-off-by: Ma Shimiao [email protected]