validation/linux_cgroups_*: Generate TAP output (and outside-validation cleanup) #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pass: * The full state object instead of just the PID, and * The full config object instead of just the cgroups path in case other properties are useful for testing (which I expect will happen once RuntimeOutsideValidate is used for more than cgroups). Signed-off-by: W. Trevor King <[email protected]>
This is right after the r.Create() call, so match the error message used after r.Create in RuntimeInsideValidate. Signed-off-by: W. Trevor King <[email protected]>
wking
force-pushed
the
outside-validation-cleanup
branch
from
028f9cc to
a14126c
Compare
|
@wking please fix your patch refer to CI logs |
wking
force-pushed
the
outside-validation-cleanup
branch
2 times, most recently
from
6a23d21 to
3bd8d43
Compare
The test harness requires TAP output. Before this commit:
# RUNTIME=runc tap ./validation/linux_cgroups_pids.t
./validation/linux_cgroups_pids.t ..................... 0/1
Skipped: 1
./validation/linux_cgroups_pids.t no tests found
total ................................................. 0/1
0 passing (191.66ms)
1 pending
After this commit:
# RUNTIME=runc tap ./validation/linux_cgroups_pids.t
./validation/linux_cgroups_pids.t ..................... 3/3
total ................................................. 3/3
3 passing (185.118ms)
ok
This commit also DRYs up some relative/absolute tests by factoring out
the shared code into util.ValidateLinuxResources* helpers.
And it adds a missing AddLinuxResourcesNetworkPriorities call;
previously we were testing for a priority that we hadn't actually
configured.
Signed-off-by: W. Trevor King <[email protected]>
Done. Thanks for the ping. |
|
LGTM |
1 similar comment
|
LGTM |
wking
added a commit
to wking/ocitools-v2
that referenced
this pull request
Apr 5, 2018
I'd accidentally committed it in 3bd8d43 (validation/linux_cgroups_*: Generate TAP output, 2018-12-13, opencontainers#542). Signed-off-by: W. Trevor King <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test harness requires TAP output. Before this pull request:
After this pull request:
This pull request also:
util.ValidateLinuxResources*helpers.AddLinuxResourcesNetworkPrioritiescall; previously we were testing for a priority that we hadn't actually configured.start→createtypo in anRuntimeOutsideValidateerror message.RuntimeOutsideValidateto be generic; passing:All of these are cleanups to the implementation which just landed via #93.