Makefile: Set CGO_ENABLED=0 for runtimetest #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And also set '-installsuffix cgo'. runtimetest is designed to be run from inside a container, which may include a mount namespace that has no linker or dynamic libraries. These changes give us a static runtimetest binary [1,2] which will work in those conditions. [1]: https://golang.org/cmd/cgo/#hdr-Using_cgo_with_the_go_command [2]: golang/go#9344 (comment) Subject: cmd/go: With Go 1.4, cannot statically link a program which imports net Signed-off-by: W. Trevor King <[email protected]>
Closed
|
LGTM |
1 similar comment
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And also set
-installsuffix cgo.runtimetestis designed to be run from inside a container, which may include a mount namespace that has no linker or dynamic libraries. These changes give us a static runtimetest binary which will work in those conditions.The approach I'm using here follows this suggestion. RunC does things a bit differently (see opencontainers/runc#401), but I'm not familiar enough with Go to contrast the approaches.