MAINTAINERS: add Zhou Hao #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
Signed-off-by: Ma Shimiao <[email protected]>
Mashimiao
force-pushed
the
add-q384566678
branch
from
a2c7f9e to
bde222d
Compare
|
LGTM |
|
LGTM |
|
LGTM |
|
On Wed, Jul 26, 2017 at 02:53:54AM +0000, Vincent Batts wrote:
(also, this is likely best sent to the dev@ mailing list as well)
Past runtime-tools maintainer changes have been GitHub only (#249,
#337), and there's nothing about dev@ in [1]. You may be thinking
about GOVERNANCE.md (which hasn't landed in runtime-tools, with the
only attempt to include it being rejected in #274). And even with
project-template's GOVERNANCE.md, maintainer addition is not clearly
attached to the GOVERNANCE.md votes without the in-flight [2]. So
until at least some of that happens, I think GitHub-only runtime-tools
votes are fine.
[1]: https://github.com/opencontainers/runtime-tools/blob/2d270b8764c02228eeb13e36f076f5ce6f2e3591/MAINTAINERS_GUIDE.md#how-are-maintainers-added
[2]: https://github.com/opencontainers/project-template/pull/20/files#diff-cc177b5b54bfdc5f9e1697d2c1ec1dc0R87
|
|
LGTM |
2 similar comments
|
LGTM |
|
LGTM |
|
8/10 maintainers approve which is good enough for the 2/3's margin required. Thank you @Mashimiao for kicking this off and sorry for the delay! |
|
Also @Mashimiao, can you send a welcome email to the [email protected] announcing the new maintainer for the runtime-tools project? Thank you! |
|
@caniszczyk of course I can, I will send later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, @opencontainers/runtime-tools-maintainers
Though we have done a lot of work, but we still have so many PRs are pending for a long time.
I think we may need more maintainers to work hard together.
Zhou Hao([email protected]) has done quite a bit of work so far!
https://github.com/opencontainers/runtime-tools/commits?author=q384566678
And he is also one of the image-tools maintainers, I believe he has enough experience and ability to manage runtime-tools.
If you agree, please reply LGTM
Signed-off-by: Ma Shimiao [email protected]