fix hooks man and help #191
Conversation
| Path to command to run in poststart hooks. This command will be run before | ||
| the container process gets launched but after the container environment and | ||
| main process has been created. | ||
| **--poststart**=[CMD[:ARG]] |
There was a problem hiding this comment.
Why the brackets around the whole thing? I'd expect:
--poststart=CMD[:ARG...]
or some such. Unless we update --poststart so --poststart= clears any existing post-start hooks.
On the other hand, maybe not worth sinking much time into this with opencontainers/runtime-spec#483 presumably being merged soon.
There was a problem hiding this comment.
On 08/17/2016 11:01 AM, W. Trevor King wrote:
Why the brackets around the whole thing? I'd expect:
--poststart=CMD[:ARG...]
brackets around the whole thing means it accepts more than one, it's a slice.
--poststart=CMD[:ARG...]
looks like only ARG accepted as slice.
There was a problem hiding this comment.
On Tue, Aug 16, 2016 at 08:07:50PM -0700, Ma Shimiao wrote:
08/17/2016 11:01 AM, W. Trevor King:
Why the brackets around the whole thing? I'd expect:
--poststart=CMD[:ARG...]
brackets around the whole thing means it accepts more than one, it's
a slice.--poststart=CMD[:ARG...]
looks like only ARG accepted as slice.
I'm used to brackets in man pages meaning “the enclosed bit is
optional” with “accepts more than one” being represented with an
ellipsis. For example:
$ man git-commit | head -n12 | tail -n6
git commit [-a | --interactive | --patch] [-s] [-v] [-u] [--amend]
[--dry-run] [(-c | -C | --fixup | --squash) ]
[-F | -m ] [--reset-author] [--allow-empty]
[--allow-empty-message] [--no-verify] [-e] [--author=]
[--date=] [--cleanup=] [--[no-]status]
[-i | -o] [-S[]] [--] [...]
Showing that is an optional argument for -S and can be
repeated.
There was a problem hiding this comment.
--bind=[[HOST-DIR:CONTAINER-DIR][:OPTIONS]]
bind also used brackets around all. Based on your opinion, it's also need to fix?
There was a problem hiding this comment.
On Tue, Aug 16, 2016 at 08:41:17PM -0700, Ma Shimiao wrote:
--bind=[[HOST-DIR:CONTAINER-DIR][:OPTIONS]]
bind also used brackets around all. Based on your opinion, it's also need to fix?
Yeah, I'd rather see:
--bind=SOURCE:DESTINATION[:OPTIONS]
with text in the description saying something like:
--bind may be set multiple times to configure multiple bind mounts.
Mashimiao
force-pushed
the
man-and-help-fix-hooks
branch
from
3902084 to
97fc2fa
Compare
| **--prestart**=CMD | ||
| Path to command to run in prestart hooks. This command will be run before | ||
| the container process gets launched but after the container environment. | ||
| **--poststart**=CMD[:ARGS..] |
Mashimiao
force-pushed
the
man-and-help-fix-hooks
branch
from
97fc2fa to
41fb3fc
Compare
|
ping @mrunalp @liangchenye |
| is stopped. | ||
|
|
||
| **--prestart**=CMD[:ARGS...] | ||
| Set commands to run in prestart hooks. Can be specified multiple times. |
Mashimiao
force-pushed
the
man-and-help-fix-hooks
branch
from
41fb3fc to
a66cd0d
Compare
Mashimiao
force-pushed
the
man-and-help-fix-hooks
branch
from
a66cd0d to
237e4ae
Compare
|
PR rebased. |
|
LGTM , but still need rebase... |
Signed-off-by: Ma Shimiao <[email protected]>
Mashimiao
force-pushed
the
man-and-help-fix-hooks
branch
from
237e4ae to
2f7d834
Compare
|
@liangchenye rebased |
|
LGTM |
Signed-off-by: Ma Shimiao [email protected]