Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add contrib directory and mv get-stage3 to that #17

Merged
merged 2 commits into from
Feb 5, 2016
Merged

add contrib directory and mv get-stage3 to that #17

merged 2 commits into from
Feb 5, 2016

Conversation

liangchenye
Copy link
Member

Signed-off-by: liangchenye [email protected]

@liangchenye
Copy link
Member Author

add contrib and mv get-stage3 to a directory called 'rootfs-gentoo-builder' (#4)

@wking not sure if you could accept the name of 'rootfs-gentoo-builder' :)

@wking
Copy link
Contributor

wking commented Jan 27, 2016

On Wed, Jan 27, 2016 at 01:11:18AM -0800, 梁辰晔 (Liang Chenye) wrote:

@wking not sure if you could accept the name of
'rootfs-gentoo-builder' :)

I don't mind, but unless we expect to have multiple builders (and I
can't see why we'd need them), I'd just call the directory
‘rootfs-builder’. Then the implementation can change from being
Gentoo-based to whatever without consumers needing to care.

Signed-off-by: liangchenye <[email protected]>
@mrunalp
Copy link
Contributor

mrunalp commented Feb 5, 2016

LGTM

mrunalp pushed a commit that referenced this pull request Feb 5, 2016
add contrib directory and mv get-stage3 to that
@mrunalp mrunalp merged commit 0ad2df8 into opencontainers:master Feb 5, 2016
wking pushed a commit to wking/ocitools-v2 that referenced this pull request Nov 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants