Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate: add new cgroup namespace option #122

Merged

Conversation

Mashimiao
Copy link

Signed-off-by: Ma Shimiao [email protected]

@@ -44,6 +44,11 @@ compatible runtime like runC to run a container.
**--cap-drop**=[]
Drop Linux capabilities

**--cgroup**=[*PATH*]
Use an Cgroup namespace. If *PATH* is set, join that namespace. If it
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/an/a

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed.

@wking
Copy link
Contributor

wking commented Jun 24, 2016

With the fix in 1, 71c8a6b will look good to me. Good catch on the
Bash-completion fixes.

@Mashimiao Mashimiao force-pushed the generate-add-cgroup-namespace-option branch from 71c8a6b to d474133 Compare June 25, 2016 02:12
@Mashimiao
Copy link
Author

ping @liangchenye @mrunalp

@mrunalp
Copy link
Contributor

mrunalp commented Jun 28, 2016

LGTM

@mrunalp mrunalp merged commit 00eb457 into opencontainers:master Jun 28, 2016
@Mashimiao Mashimiao deleted the generate-add-cgroup-namespace-option branch November 14, 2016 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants