-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
specs-go/config: add Intel RDT/CAT Linux support #630
specs-go/config: add Intel RDT/CAT Linux support #630
Conversation
50bf471
to
80ba92f
Compare
This PR will obsolete #267 for the change of Intel RDT/CAT kernel interface. |
@xiaochenshen Is it OK to hold-off on this until v1.1 ? |
@RobDolinMS What is the plan or schedule of v1.1? |
c3772a6
to
bc14fe0
Compare
3d7cb94
to
59c61bd
Compare
config-linux.md
Outdated
|
||
"linux": { | ||
"resources": { | ||
"intelRdt": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We think this should not be part of resources and should be added inside the linux
struct, not resources
.
Resources only contains cgroup information for us.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After this, we should be good to merge this in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@crosbymichael @mrunalp Thank you for code review.
I will work on this together with opencontainers/runc#1279
Add support for Intel Resource Director Technology (RDT) / Cache Allocation Technology (CAT). Add L3 cache resource constraints in Linux-specific configuration. This is the prerequisite of this runc proposal: opencontainers/runc#433 For more information about Intel RDT/CAT, please refer to: opencontainers/runc#433 Signed-off-by: Xiaochen Shen <[email protected]>
59c61bd
to
73a6002
Compare
@crosbymichael The PR opencontainers/runc#1279 has been updated accordingly. |
1 similar comment
So this will still depend on |
@vbatts And also the case will be handled in opencontainers/runc#1279 when hardware or kernel doesn't support Intel RDT/CAT. |
Fix opencontainers#630 Signed-off-by: zhouhao <[email protected]>
Add support for Intel Resource Director Technology (RDT) / Cache Allocation
Technology (CAT). Add L3 cache resource constraints in Linux-specific
configuration.
This is the prerequisite of this runc proposal:
opencontainers/runc#433
For more information about Intel RDT/CAT, please refer to:
opencontainers/runc#433
Signed-off-by: Xiaochen Shen [email protected]