Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specs-go/config: add Intel RDT/CAT Linux support #630

Merged

Conversation

xiaochenshen
Copy link
Contributor

Add support for Intel Resource Director Technology (RDT) / Cache Allocation
Technology (CAT). Add L3 cache resource constraints in Linux-specific
configuration.

This is the prerequisite of this runc proposal:
opencontainers/runc#433

For more information about Intel RDT/CAT, please refer to:
opencontainers/runc#433

Signed-off-by: Xiaochen Shen [email protected]

@xiaochenshen xiaochenshen force-pushed the rdt-cat-resctrl-cgroup-v1 branch 3 times, most recently from 50bf471 to 80ba92f Compare November 21, 2016 16:10
@xiaochenshen
Copy link
Contributor Author

This PR will obsolete #267 for the change of Intel RDT/CAT kernel interface.

@RobDolinMS
Copy link
Collaborator

@xiaochenshen Is it OK to hold-off on this until v1.1 ?

@RobDolinMS RobDolinMS added this to the 1.1.0 milestone Jan 11, 2017
@xiaochenshen
Copy link
Contributor Author

@RobDolinMS What is the plan or schedule of v1.1?
This is the dependent PR of opencontainers/runc#1198, and it is part of opencontainers/runc#433. I am fine to hold-off this PR until the issues in opencontainers/runc#1198 are addressed.

@xiaochenshen xiaochenshen force-pushed the rdt-cat-resctrl-cgroup-v1 branch 4 times, most recently from c3772a6 to bc14fe0 Compare January 17, 2017 21:28
@xiaochenshen xiaochenshen force-pushed the rdt-cat-resctrl-cgroup-v1 branch 2 times, most recently from 3d7cb94 to 59c61bd Compare March 8, 2017 07:13
config-linux.md Outdated

"linux": {
"resources": {
"intelRdt": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We think this should not be part of resources and should be added inside the linux struct, not resources.

Resources only contains cgroup information for us.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After this, we should be good to merge this in.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crosbymichael @mrunalp Thank you for code review.
I will work on this together with opencontainers/runc#1279

Add support for Intel Resource Director Technology (RDT) / Cache Allocation
Technology (CAT). Add L3 cache resource constraints in Linux-specific
configuration.

This is the prerequisite of this runc proposal:
opencontainers/runc#433

For more information about Intel RDT/CAT, please refer to:
opencontainers/runc#433

Signed-off-by: Xiaochen Shen <[email protected]>
@xiaochenshen xiaochenshen force-pushed the rdt-cat-resctrl-cgroup-v1 branch from 59c61bd to 73a6002 Compare March 10, 2017 09:54
@xiaochenshen
Copy link
Contributor Author

@crosbymichael
To address your suggestion in #630 (review):
IntelRdt struct has been moved out of Resources and inside Linux now.

The PR opencontainers/runc#1279 has been updated accordingly.

@crosbymichael
Copy link
Member

crosbymichael commented Mar 10, 2017

LGTM

Approved with PullApprove

1 similar comment
@mrunalp
Copy link
Contributor

mrunalp commented Mar 10, 2017

LGTM

Approved with PullApprove

@mrunalp mrunalp merged commit 76159da into opencontainers:master Mar 10, 2017
@vbatts
Copy link
Member

vbatts commented Mar 13, 2017

So this will still depend on CONFIG_INTEL_RDT_A in the kernel, which defaults to N http://www.cateee.net/lkddb/web-lkddb/INTEL_RDT_A.html

@xiaochenshen
Copy link
Contributor Author

@vbatts
From my understanding, it doesn't matter if the kernel config is enabled or not by default. Users can change the kernel config when they want to enable the feature in kernel when the hardware platform supports Intel RDT/CAT.

And also the case will be handled in opencontainers/runc#1279 when hardware or kernel doesn't support Intel RDT/CAT.

@vbatts vbatts mentioned this pull request Jul 5, 2017
zhouhao3 pushed a commit to zhouhao3/runtime-spec that referenced this pull request Jul 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants