-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add references to Windows containers #554
Conversation
Signed-off-by: Rob Dolin <[email protected]>
Signed-off-by: Rob Dolin <[email protected]
@@ -0,0 +1,3 @@ | |||
# Windows Application Container Configuration | |||
|
|||
Windows application containers can be configured using the following properties. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where's the meat? Is this supposed to have stuff from #504?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wking To your question of "Where's the beef", there's not much here yet. I would expect that #504 and similar would be added over time. My desire with this PR it clear that it is the intent of OCI to support Linux, Solaris, and Windows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On Thu, Sep 01, 2016 at 04:11:39PM -0700, Rob Dolin (MSFT) wrote:
@@ -0,0 +1,3 @@
+# Windows Application Container Configuration
+
+Windows application containers can be configured using the following properties.… My desire with this PR it clear that it is the intent of OCI to
support Linux, Solaris, and Windows.
Then how about dropping this file (until you have Windows-specific
settings to put into it) and using:
- Windows containers: runtime.md and config.md
in README.md?
Signed-off-by: Rob Dolin [email protected] |
@opencontainers/runtime-spec-maintainers Per conversation on OCI Dev ConCall, please LGTM and merge. Thanks. :) |
On Wed, Sep 07, 2016 at 02:19:30PM -0700, Rob Dolin (MSFT) wrote:
Ah, looks like the Signed-off-by in d407660 is missing a trailing |
@RobDolinMS yeah, I think the DCO check is a firm blocker (AIUI, IANAL); if your current toolchain can't amend/force, could you clone your branch elsewhere and amend/force there? Otherwise I think you're stuck with a resubmit. 😞 |
On Thu, Sep 08, 2016 at 01:50:48PM -0700, Tianon Gravi wrote:
I believe this has been dealt with in the past by having the merging |
Working on a replacement for this with more meat, and meeting with Windows Containers experts later today |
Closing per above comments. |
On Wed, Sep 14, 2016 at 04:16:45PM -0700, Rob Dolin (MSFT) wrote:
With the Windows changes coming in in a stream of tiny PRs (which I |
Signed-off-by: Rob Dolin [email protected]