Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schema/validate: Allow schema identifiers to contain a URL scheme #490

Merged

Conversation

wking
Copy link
Contributor

@wking wking commented Jun 6, 2016

And only fall back to assuming they're a local file if they don't
already contain :// (which is unlikely to show up in local paths).
This makes it easy to validate configurations against different
versions of the JSON Schema (e.g. v0.5.0 or v1.0.0-rc1).

Ping @vbatts.

And only fall back to assuming they're a local file if they don't
already contain :// (which is unlikely to show up in local paths).
This makes it easy to validate configurations against different
versions of the JSON Schema (e.g. v0.5.0 or v1.0.0-rc1).

Signed-off-by: W. Trevor King <[email protected]>
@tianon
Copy link
Member

tianon commented Nov 4, 2016

@vbatts what're your thoughts on this? I'm personally somewhere between neutral to +1 on the functionality since it seems like a nifty feature (although I'm not certain whether just testing whether the path contains :// somewhere is sufficient or whether it'd make sense to do something with testing for file existence / valid URL parsing?)

@wking
Copy link
Contributor Author

wking commented Nov 4, 2016

On Fri, Nov 04, 2016 at 03:39:26PM -0700, Tianon Gravi wrote:

… although I'm not certain whether just testing whether the path
contains :// somewhere is sufficient or whether it'd make sense to
do something with testing for file existence / valid URL parsing?…

I think :// is unlikely in a genric filesystem path. And folks who
want to make it explicit can always use file://yes://I://am://crazy://
;).

@mrunalp
Copy link
Contributor

mrunalp commented Jan 11, 2017

@vbatts PTAL

@vbatts
Copy link
Member

vbatts commented Jan 18, 2017

LGTM

Approved with PullApprove

1 similar comment
@mrunalp
Copy link
Contributor

mrunalp commented Jan 18, 2017

LGTM

Approved with PullApprove

@mrunalp mrunalp merged commit 937ea7b into opencontainers:master Jan 18, 2017
@wking wking deleted the json-schema-validate-http-schema branch January 19, 2017 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants