spec: add scheduler entity #1188
Conversation
giuseppe
requested review from
AkihiroSuda,
crosbymichael,
cyphar,
dqminh,
hqhq,
kolyshkin,
mrunalp,
thaJeztah,
tianon and
vbatts
as code owners
|
LGTM |
|
Thanks, @giuseppe |
specs-go/config.go
Outdated
| Policy LinuxSchedulerPolicy `json:"policy"` | ||
|
|
||
| // Nice is the nice value for the process, which affects its priority. | ||
| Nice int32 `json:"nice"` |
There was a problem hiding this comment.
If you know, please let me know, does this apply to process groups?:pray: Or only one process?
I tried reading the man page but it just wasn't clear to me.
https://man7.org/linux/man-pages/man2/sched_setattr.2.html
There was a problem hiding this comment.
from my understanding that is only for one process or thread:
The sched_setattr() system call sets the scheduling policy and
associated attributes for the thread whose ID is specified in
pid. If pid equals zero, the scheduling policy and attributes of
the calling thread will be set
do you see a different behavior?
There was a problem hiding this comment.
I agree with you. I thought the user would expect the nice value to be applied to all processes in the container? What do you think?
There was a problem hiding this comment.
How about specifying whether it applies to the container init process alone or to all processes in the container?
| * `SCHED_BATCH` | ||
| * `SCHED_ISO` | ||
| * `SCHED_IDLE` | ||
| * `SCHED_DEADLINE` |
There was a problem hiding this comment.
SCHED_DEADLINE seems to sometimes return an EBUSY error. Do you want the error numbers to follow these when the set fails?
https://man7.org/linux/man-pages/man2/sched_setattr.2.html
There seems to be some difficulty in using SCHED_DEADLINE with cpuset. can we consider removing SCHED_DEADLINE from support?
https://www.kernel.org/doc/Documentation/scheduler/sched-deadline.txt
There was a problem hiding this comment.
I don't think it is required to support it, I am just listing the possible values for now (e.g. SCHED_ISO is not even implemented yet)
There was a problem hiding this comment.
I will leave it up to you to specify about it in the oci-spec, but there are some things that probably cannot be handled. I thought users might expect to be able to use them.
extend the process struct to represent scheduling attributes for a process based on the sched_setattr(2) syscall. Signed-off-by: Giuseppe Scrivano <[email protected]>
|
@thaJeztah could you PTAL? |
|
Any more reviewers needed, or are we good to go? (forgot how many we want for such changes in this repository 🙈) |
|
Ah! Thanks @AkihiroSuda 😂 |
Spec: opencontainers/runtime-spec#1188 Fix: opencontainers#3895 Signed-off-by: utam0k <[email protected]>
Spec: opencontainers/runtime-spec#1188 Fix: opencontainers#3895 Signed-off-by: utam0k <[email protected]>
Spec: opencontainers/runtime-spec#1188 Fix: opencontainers#3895 Signed-off-by: utam0k <[email protected]>
Spec: opencontainers/runtime-spec#1188 Fix: opencontainers#3895 Signed-off-by: utam0k <[email protected]> Signed-off-by: lifubang <[email protected]>
Spec: opencontainers/runtime-spec#1188 Fix: opencontainers#3895 Signed-off-by: utam0k <[email protected]> Signed-off-by: lifubang <[email protected]>
Spec: opencontainers/runtime-spec#1188 Fix: opencontainers#3895 Signed-off-by: utam0k <[email protected]> Signed-off-by: lifubang <[email protected]>
Spec: opencontainers/runtime-spec#1188 Fix: opencontainers#3895 Signed-off-by: utam0k <[email protected]> Signed-off-by: lifubang <[email protected]>
Spec: opencontainers/runtime-spec#1188 Fix: opencontainers#3895 Signed-off-by: utam0k <[email protected]> Signed-off-by: lifubang <[email protected]>
Spec: opencontainers/runtime-spec#1188 Fix: opencontainers#3895 Signed-off-by: utam0k <[email protected]> Signed-off-by: lifubang <[email protected]>
Spec: opencontainers/runtime-spec#1188 Fix: opencontainers#3895 Signed-off-by: utam0k <[email protected]> Signed-off-by: lifubang <[email protected]>
Spec: opencontainers/runtime-spec#1188 Fix: opencontainers#3895 Co-authored-by: utam0k <[email protected]> Signed-off-by: lifubang <[email protected]>
Spec: opencontainers/runtime-spec#1188 Fix: opencontainers#3895 Co-authored-by: utam0k <[email protected]> Signed-off-by: lifubang <[email protected]>
Spec: opencontainers/runtime-spec#1188 Fix: opencontainers#3895 Co-authored-by: utam0k <[email protected]> Signed-off-by: lifubang <[email protected]>
Spec: opencontainers/runtime-spec#1188 Fix: opencontainers#3895 Co-authored-by: utam0k <[email protected]> Signed-off-by: utam0k <[email protected]> Signed-off-by: lifubang <[email protected]>
Spec: opencontainers/runtime-spec#1188 Fix: opencontainers#3895 Co-authored-by: utam0k <[email protected]> Signed-off-by: utam0k <[email protected]> Signed-off-by: lifubang <[email protected]>
Spec: opencontainers/runtime-spec#1188 Fix: opencontainers#3895 Co-authored-by: lifubang <[email protected]> Signed-off-by: utam0k <[email protected]> Signed-off-by: lifubang <[email protected]>
Spec: opencontainers/runtime-spec#1188 Fix: opencontainers/runc#3895 Co-authored-by: lifubang <[email protected]> Signed-off-by: utam0k <[email protected]> Signed-off-by: lifubang <[email protected]>
extend the process struct to represent scheduling attributes for a process based on the sched_setattr(2) syscall.
I've been playing with crun and it is currently implemented as an annotation:
but I think this makes sense as part of the runtime-specs without the custom hack.