Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add youki to implementations.md #1126

Merged
merged 2 commits into from
Oct 12, 2021
Merged

Conversation

utam0k
Copy link
Member

@utam0k utam0k commented Sep 28, 2021

youki has passed all integration tests of runtime-tools. Is it possible to have youki included in this list?
The implementation status of youki is summarized here.
https://github.com/containers/youki#status-of-youki

I've also put the list in alphabetical order.

Render

@utam0k
Copy link
Member Author

utam0k commented Sep 30, 2021

@tianon @cyphar
Could you please review it?

implementations.md Outdated Show resolved Hide resolved
Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for couple of nits

@utam0k
Copy link
Member Author

utam0k commented Oct 7, 2021

@tianon @kolyshkin
Thanks for the review. Which one should I fix? If you'd like, you can use Resolve conversation and ask you to leave only comments that should be fixed? It would be great if you could guide me.

Copy link
Member

@tianon tianon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@utam0k
Copy link
Member Author

utam0k commented Oct 7, 2021

@cyphar PTAL. It seems we need your review.

@utam0k
Copy link
Member Author

utam0k commented Oct 12, 2021

@vbatts Can I ask you to review this?

@vbatts vbatts merged commit ab23082 into opencontainers:master Oct 12, 2021
@AkihiroSuda AkihiroSuda mentioned this pull request Jan 24, 2023
@AkihiroSuda AkihiroSuda added this to the v1.1.0 milestone Feb 1, 2023
@AkihiroSuda AkihiroSuda mentioned this pull request Jun 26, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants