config-linux: Add Intel RDT CMT and MBM Linux support

[Creatone]

Add support for Intel Resource Director Technology (RDT) /
Cache Monitoring Technology (CMT) and Memory Bandwidth Monitoring (MBM).

Example:

"linux": {
    "intelRdt": {
        "enableCMT": true,
        "enableMBM": true
    }
}

This is the prerequisite of this runc proposal:
opencontainers/runc#2519

For more information about Intel RDT CMT and MBM, please refer to:
opencontainers/runc#2519

Signed-off-by: Paweł Szulik [email protected]

[Creatone]

@xiaochenshen

[xiaochenshen]

"linux": {
    "intelRdt": {
        "monitoring": true
    }
}

@Creatone
Thank you for adding this to support Intel RDT monitoring features for OCI runtime-spec and runc.
Apart from the nitpicking, this change LGTM.

[xiaochenshen]

LGTM

[caniszczyk]

RFC @opencontainers/runtime-spec-maintainers

[AkihiroSuda]

Brief description about RDT, CMT, and MBM would be appreciated

[Creatone]

Description of IntelRDT is above. Added CMT and MBM information.

[xiaochenshen]

LGTM (apart from the nitpicking).

[xiaochenshen]

LGTM

[tianon]

Do you foresee any reason for this to need to be more than just a simple boolean in the future? As an example, can each of the monitoring features mentioned be enabled separately, and is there a use case for doing so?

[Creatone]

@tianon Good point. It would be a good thing that the user can choose which features want to use.

[xiaochenshen]

Do you foresee any reason for this to need to be more than just a simple boolean in the future? As an example, can each of the monitoring features mentioned be enabled separately, and is there a use case for doing so?

@tianon @Creatone
It makes sense to split Intel RDT monitoring features (CMT and MBM) in config because we could selectively enable/disable Intel RDT sub-features by kernel command line parameter rdt= even though hardware supports both monitoring features. See more details in option rdt= in https://www.kernel.org/doc/Documentation/admin-guide/kernel-parameters.txt

[vbatts]

Generally speaking, is this a per container feature? reading the docs looks like it is a kernel global, so does this really only apply for kata-containers that will boot a container/pod into its own kernel that this could apply?

Also, it looks like commit 8f6cf10 has dangling whitespace issues.

[xiaochenshen]

Generally speaking, is this a per container feature?

@vbatts Yes, this is a per container feature which depends on Intel RDT kernel support on host.
You could find more details about Intel RDT support for OCI/runc container from:
opencontainers/runc#433
opencontainers/runc#1596
opencontainers/runc#2292

reading the docs looks like it is a kernel global, so does this really only apply for kata-containers that will boot a container/pod into its own kernel that this could apply?

This is not targeted for VM or VM based container (e.g., Kata containers).

[vbatts]

gotcha

LGTM

[tianon]

LGTM

(but I'd love to get at least one more @opencontainers/runtime-spec-maintainers member to take a look 🙏 ❤️)

[kolyshkin]

The commits need to be squashed. It _usually) does not make sense to introduce something and then replace it with something else in the same PR.

Left some minor comments as well. PTAL @Creatone

[Creatone]

@kolyshkin PTAL

[kolyshkin]

@Creatone the example in the commit message no longer reflects reality -- please update.

[Creatone]

@kolyshkin PTAL

[Creatone]

@caniszczyk @crosbymichael @cyphar @dqminh @giuseppe @hqhq @mrunalp @tianon @vbatts @vishh PTAL, it's waiting from Nov 2020

[giuseppe]

sorry for the delay.

LGTM