Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: Fix golint URL used in go get #1075

Merged
merged 1 commit into from
Nov 21, 2020

Conversation

rata
Copy link
Member

@rata rata commented Nov 5, 2020

Otherwise, commands like "make install.tools" fail with:

$ make install.tools
go get -u github.com/golang/lint/golint
code in directory /<path>/github.com/golang/lint/golint expects import "golang.org/x/lint/golint"

The github repository says this URL should be used for go get. After
this patch, make install.tools works just fine.

Signed-off-by: Rodrigo Campos [email protected]

Otherwise, commands like "make install.tools" fail with:

	$ make install.tools
	go get -u github.com/golang/lint/golint
	code in directory /<path>/github.com/golang/lint/golint expects import "golang.org/x/lint/golint"

The github repository says this URL should be used for go get. After
this patch, make install.tools works just fine.

Signed-off-by: Rodrigo Campos <[email protected]>
Copy link
Member

@tianon tianon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giuseppe
Copy link
Member

giuseppe commented Nov 9, 2020

LGTM

Approved with PullApprove

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianon tianon merged commit 7413a7f into opencontainers:master Nov 21, 2020
@rata rata deleted the rata/fix-golint-url branch November 25, 2020 13:06
@rata
Copy link
Member Author

rata commented Nov 25, 2020

Thanks!

@AkihiroSuda AkihiroSuda mentioned this pull request Jan 24, 2023
@AkihiroSuda AkihiroSuda added this to the v1.1.0 milestone Feb 1, 2023
@AkihiroSuda AkihiroSuda mentioned this pull request Jun 26, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants