Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINTAINERS: Add @cyphar as maintainer #1043

Merged
merged 1 commit into from
May 20, 2020
Merged

MAINTAINERS: Add @cyphar as maintainer #1043

merged 1 commit into from
May 20, 2020

Conversation

giuseppe
Copy link
Member

I propose Aleksa Sarai (@cyphar) to be added to the runtime-spec maintainers.

Signed-off-by: Giuseppe Scrivano [email protected]

@giuseppe
MAINTAINERS: Add @cyphar as maintainer
d759f35 
Signed-off-by: Giuseppe Scrivano <[email protected]>
@giuseppe
Copy link
Member Author

@crosbymichael @mrunalp @vbatts @dqminh @tianon @hqhq PTAL

@hqhq
Copy link
Contributor

hqhq commented May 13, 2020 •
edited by caniszczyk
Loading

LGTM

Approved with PullApprove

1 similar comment
@mrunalp
Copy link
Contributor

mrunalp commented May 13, 2020 •
edited by caniszczyk
Loading

LGTM

Approved with PullApprove

@giuseppe
Copy link
Member Author

there are two LGTM, can it be merged?

@cyphar
Copy link
Member

cyphar commented May 17, 2020 •
edited by vbatts
Loading

For maintainer additions, you need a 2/3rd vote. Namely, we need 4 of the following folks to LGTM it:

@dqminh
Copy link
Contributor

dqminh commented May 18, 2020 •
edited by caniszczyk
Loading

LGTM.

This is great !

Approved with PullApprove

@vbatts
Copy link
Member

vbatts commented May 20, 2020 •
edited by caniszczyk
Loading

LGTM

Approved with PullApprove

@vbatts vbatts merged commit 237cc4f into opencontainers:master May 20, 2020
@vbatts
Copy link
Member

vbatts commented May 20, 2020

with a 4/6 vote

@AkihiroSuda AkihiroSuda mentioned this pull request Jan 24, 2023
Merged
@AkihiroSuda AkihiroSuda added this to the v1.1.0 milestone Feb 1, 2023
@AkihiroSuda AkihiroSuda mentioned this pull request Jun 26, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.
7 participants
@giuseppe @hqhq @mrunalp @cyphar @dqminh @vbatts @AkihiroSuda