Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spec should have a reference to RFC2119 #256

Closed
mikebrow opened this issue Nov 24, 2015 · 4 comments
Closed

Spec should have a reference to RFC2119 #256

mikebrow opened this issue Nov 24, 2015 · 4 comments

Comments

@mikebrow
Copy link
Member

For clarity purposes the words like MUST should be defined by the spec. For example:

The key words "MUST", "MUST NOT", "REQUIRED", "SHALL", "SHALL NOT", "SHOULD", "SHOULD NOT", "RECOMMENDED", "MAY", and "OPTIONAL" in this document are to be interpreted as described in RFC 2119.. link: http://tools.ietf.org/html/rfc2119
@wking
Copy link
Contributor

wking commented Nov 25, 2015

On Tue, Nov 24, 2015 at 02:36:55PM -0800, Mike Brown wrote:

The key words "MUST", "MUST NOT", "REQUIRED", "SHALL", "SHALL NOT",
"SHOULD", "SHOULD NOT", "RECOMMENDED", "MAY", and "OPTIONAL" in this
document are to be interpreted as described in RFC 2119.. link:
http://tools.ietf.org/html/rfc2119

+1.

@philips
Copy link
Contributor

philips commented Nov 25, 2015

+1. We should probably have some huge flag day where we agree to make these
changes.

On Tue, Nov 24, 2015 at 10:31 PM W. Trevor King [email protected]
wrote:

On Tue, Nov 24, 2015 at 02:36:55PM -0800, Mike Brown wrote:

The key words "MUST", "MUST NOT", "REQUIRED", "SHALL", "SHALL NOT",
"SHOULD", "SHOULD NOT", "RECOMMENDED", "MAY", and "OPTIONAL" in this
document are to be interpreted as described in RFC 2119.. link:
http://tools.ietf.org/html/rfc2119

+1.

—
Reply to this email directly or view it on GitHub
#256 (comment)
.

@vbatts
Copy link
Member

vbatts commented Dec 1, 2015

👍

@mikebrow mikebrow mentioned this issue Dec 1, 2015
Merged
wking added a commit to wking/oci-command-line-api that referenced this issue Dec 3, 2015
@wking
Use RFC 2119's keywords (MUST, MAY, ...)
24ce5cc 
This is likely where opencontainers/specs is going [1], although the
PR hasn't landed yet [2].

[1]: opencontainers/runtime-spec#256
[2]: opencontainers/runtime-spec#260
@wking
Copy link
Contributor

wking commented Dec 5, 2015 via email

wking added a commit to wking/oci-command-line-api that referenced this issue Dec 5, 2015
@wking
Use RFC 2119's keywords (MUST, MAY, ...)
527f3c6 
This approach has landed in opencontainers/specs [1,2].  You can find
the RFC here [3].

[1]: opencontainers/runtime-spec#256
[2]: opencontainers/runtime-spec#260
[3]: http://tools.ietf.org/html/rfc2119

Signed-off-by: W. Trevor King <[email protected]>
@hqhq hqhq closed this as completed Dec 7, 2015
wking added a commit to wking/oci-command-line-api that referenced this issue Dec 9, 2015
@wking
Use RFC 2119's keywords (MUST, MAY, ...)
52ca435 
This approach has landed in opencontainers/specs [1,2].  You can find
the RFC here [3].

[1]: opencontainers/runtime-spec#256
[2]: opencontainers/runtime-spec#260
[3]: http://tools.ietf.org/html/rfc2119

Signed-off-by: W. Trevor King <[email protected]>
wking added a commit to wking/oci-command-line-api that referenced this issue Dec 11, 2015
@wking
Use RFC 2119's keywords (MUST, MAY, ...)
6f5ae34 
This approach has landed in opencontainers/specs [1,2].  You can find
the RFC here [3].

[1]: opencontainers/runtime-spec#256
[2]: opencontainers/runtime-spec#260
[3]: http://tools.ietf.org/html/rfc2119

Signed-off-by: W. Trevor King <[email protected]>
wking added a commit to wking/oci-command-line-api that referenced this issue Dec 12, 2015
@wking
Use RFC 2119's keywords (MUST, MAY, ...)
be67069 
This approach has landed in opencontainers/specs [1,2].  You can find
the RFC here [3].

[1]: opencontainers/runtime-spec#256
[2]: opencontainers/runtime-spec#260
[3]: http://tools.ietf.org/html/rfc2119

Signed-off-by: W. Trevor King <[email protected]>
wking added a commit to wking/oci-command-line-api that referenced this issue Dec 17, 2015
@wking
Use RFC 2119's keywords (MUST, MAY, ...)
e41ffc1 
This approach has landed in opencontainers/specs [1,2].  You can find
the RFC here [3].

[1]: opencontainers/runtime-spec#256
[2]: opencontainers/runtime-spec#260
[3]: http://tools.ietf.org/html/rfc2119

Signed-off-by: W. Trevor King <[email protected]>
Reviewed-by: Mike Brown <[email protected]>
@wking wking mentioned this issue May 27, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@philips @vbatts @wking @hqhq @mikebrow