-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tracker] Platform/Compiler agnostic schema #166
Comments
On Wed, Sep 09, 2015 at 10:30:24AM -0700, Vincent Batts wrote:
How is this related to #135?
JSON Schema is fine with me (although their docs can be hard to browse |
I think a richer schema is definitely beneficial. Does json schema support things like one field can have different types (like uid/gid can be string on windows iirc ), and |
On Wed, Sep 09, 2015 at 11:25:47AM -0700, Daniel, Dao Quang Minh wrote:
That sounds like oneOf.
Yes, see 1. Maybe the approach should be “start translating the spec to JSON |
On Wed, Sep 09, 2015 at 07:53:07PM -0700, Vincent Batts wrote:
#135 is a step towards a platform-agnostic Go spec. Is that a valid |
This is about not yak shaving, and actually trying to solve the problem On Wed, Sep 9, 2015 at 11:21 PM, W. Trevor King [email protected]
|
#179 is an approach to this. |
Any approach that changes json to other protocol would be an endless progress. |
another part of this is code generation. As mentioned in #185 (comment), it is a goal of having a schema that is language agnostic. /cc @LK4D4 |
FWIW, we've been using JSON schemas to great effect (example here). I'd agree their docs are a little wonky beyond a few demos, but there are a lot of options for validation and it seems a well-tread path. It's also convenient that a schema is itself JSON, so you're not mucking about with various formats & protocols. I don't want to claim that it's the best option for this use case, in fact I'd be interested if there are alternative proposals, but it has yet to bite us in our applications. YMMV. |
This introduces verbiage of fields that may occur in json (technically optional), but is required on certain platforms (e.g. Linux). Not adding a "name" string, as that is not a requirement yet. In the event a windows runtime shows up, I could imagine an `sid`, but we'll get to that when it happens. Closes opencontainers#135 Related to opencontainers#166 Signed-off-by: Vincent Batts <[email protected]>
This introduces verbiage of fields that may occur in json (technically optional), but is required on certain platforms (e.g. Linux). The JSON document will look the same as it presently does, but now the reference source compiles regardless of platform. Not adding a "name" string to the user sturct, as that is not a requirement yet. In the event a windows runtime shows up, I could imagine an `sid` on the user struct, but we'll get to that when it happens. Closes opencontainers#135 Related to opencontainers#166 Signed-off-by: Vincent Batts <[email protected]>
This introduces verbiage of fields that may occur in json (technically optional), but is required on certain platforms (e.g. Linux). The JSON document will look the same as it presently does, but now the reference source compiles regardless of platform. Not adding a "name" string to the user sturct, as that is not a requirement yet. In the event a windows runtime shows up, I could imagine an `sid` on the user struct, but we'll get to that when it happens. Closes opencontainers#135 Related to opencontainers#166 Signed-off-by: Vincent Batts <[email protected]>
This introduces verbiage of fields that may occur in json (technically optional), but is required on certain platforms (e.g. Linux). The JSON document will look the same as it presently does, but now the reference source compiles regardless of platform. Not adding a "name" string to the user sturct, as that is not a requirement yet. In the event a windows runtime shows up, I could imagine an `sid` on the user struct, but we'll get to that when it happens. Closes opencontainers#135 Related to opencontainers#166 Signed-off-by: Vincent Batts <[email protected]>
This introduces verbiage of fields that may occur in json (technically optional), but is required on certain platforms (e.g. Linux). The JSON document will look the same as it presently does, but now the reference source compiles regardless of platform. Not adding a "name" string to the user sturct, as that is not a requirement yet. In the event a windows runtime shows up, I could imagine an `sid` on the user struct, but we'll get to that when it happens. Closes opencontainers#135 Related to opencontainers#166 Signed-off-by: Vincent Batts <[email protected]>
This introduces verbiage of fields that may occur in json (technically optional), but is required on certain platforms (e.g. Linux). The JSON document will look the same as it presently does, but now the reference source compiles regardless of platform. Not adding a "name" string to the user sturct, as that is not a requirement yet. In the event a windows runtime shows up, I could imagine an `sid` on the user struct, but we'll get to that when it happens. Closes opencontainers#135 Related to opencontainers#166 Signed-off-by: Vincent Batts <[email protected]>
see #313 |
Thanks for the pointer @kofalt |
@crosbymichael I've added this to the v0.4.0 milestone, as you had added it to #324 |
This introduces verbiage of fields that may occur in json (technically optional), but is required on certain platforms (e.g. Linux). The JSON document will look the same as it presently does, but now the reference source compiles regardless of platform. Not adding a "name" string to the user sturct, as that is not a requirement yet. In the event a windows runtime shows up, I could imagine an `sid` on the user struct, but we'll get to that when it happens. Closes opencontainers#135 Related to opencontainers#166 Signed-off-by: Vincent Batts <[email protected]>
This introduces verbiage of fields that may occur in json (technically optional), but is required on certain platforms (e.g. Linux). The JSON document will look the same as it presently does, but now the reference source compiles regardless of platform. Not adding a "name" string to the user sturct, as that is not a requirement yet. In the event a windows runtime shows up, I could imagine an `sid` on the user struct, but we'll get to that when it happens. Closes opencontainers#135 Related to opencontainers#166 Signed-off-by: Vincent Batts <[email protected]>
This should be resolved, as #310 is merged. Let me know if this needs further iteration. |
This introduces verbiage of fields that may occur in json (technically optional), but is required on certain platforms (e.g. Linux). The JSON document will look the same as it presently does, but now the reference source compiles regardless of platform. Not adding a "name" string to the user sturct, as that is not a requirement yet. In the event a windows runtime shows up, I could imagine an `sid` on the user struct, but we'll get to that when it happens. Closes opencontainers#135 Related to opencontainers#166 Signed-off-by: Vincent Batts <[email protected]>
like #135 began to fix, this needs to track our movement from golang compiler constrained schema, to something like json-schema.
At that point, we can have the provided
*.go
(if at all) as a reference for valid structs for the schema.The text was updated successfully, but these errors were encountered: