Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.1] libct/system: ClearRlimitNofileCache for go 1.23 #4299

Merged
merged 1 commit into from
Jun 6, 2024
Merged

[1.1] libct/system: ClearRlimitNofileCache for go 1.23 #4299

merged 1 commit into from
Jun 6, 2024

Commits on Jun 5, 2024

  1. [1.1] libct/system: ClearRlimitNofileCache for go 1.23 

    Go 1.23 tightens access to internal symbols, and even puts runc into
"hall of shame" for using an internal symbol (recently added by commit
da68c8e). So, while not impossible, it becomes harder to access those
internal symbols, and it is a bad idea in general.

Since Go 1.23 includes https://go.dev/cl/588076, we can clean the
internal rlimit cache by setting the RLIMIT_NOFILE for ourselves,
essentially disabling the rlimit cache.

Once Go 1.22 is no longer supported, we will remove the go:linkname hack.

(cherry picked from commit 584afc6)
Signed-off-by: Kir Kolyshkin <[email protected]>
    @kolyshkin
    kolyshkin committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    096e6f8 View commit details
    Browse the repository at this point in the history