Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/int: fix flaky kill tests #4179

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

kolyshkin
Copy link
Contributor

@kolyshkin kolyshkin commented Jan 25, 2024

It takes some time for the kernel to kill the process (and remove its
PID from cgroup.procs). To ensure we don't have flakes from reading
cgroup.procs right after the kill, check and wait for processes to
actually be gone.

Fixes: #4163

@kolyshkin kolyshkin marked this pull request as draft January 25, 2024 01:44
@kolyshkin kolyshkin force-pushed the ci-fix-kill-flake branch 7 times, most recently from 142bcb7 to c5f3ad5 Compare January 30, 2024 21:26
@kolyshkin kolyshkin marked this pull request as ready for review January 30, 2024 22:20
@kolyshkin kolyshkin force-pushed the ci-fix-kill-flake branch 2 times, most recently from 696fc90 to a060e35 Compare February 12, 2024 22:46
It takes some time for the kernel to kill the process (and remove its
PID from cgroup.procs). To ensure we don't have flakes from reading
cgroup.procs right after the kill, check and wait for processes to
actually be gone.

Fixes: 4163
Reported-by: [email protected]
Signed-off-by: Kir Kolyshkin <[email protected]>
@cyphar cyphar merged commit 44114d3 into opencontainers:main Mar 15, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flaky test: kill KILL [host pidns]
3 participants