Fix Vagrant caching #3880
Merged
Fix Vagrant caching #3880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolyshkin
force-pushed
the
fix-vagrant-cache
branch
from
da48dfa to
99fad81
Compare
As of today, vagrant stopped working, my best guess is due to bad caching. Here's an excerpt from logs: ... vagrant plugin install vagrant-libvirt Installing the 'vagrant-libvirt' plugin. This can take a few minutes... Building native extensions. This could take a while... Installed the plugin 'vagrant-libvirt (0.12.1)'! ... uname -s ; cat Vagrantfile.$DISTRO Linux ... Downloaded 481Mb in 4.096201s. Cache hit for vagrant-8be35383dc00f23d080ff00b2a724c938d650254861f26b67624c28e3fe5e6ae! ... Vagrant failed to initialize at a very early stage: The plugins failed to initialize correctly. This may be due to manual modifications made within the Vagrant home directory. ... Error message given during initialization: Unable to resolve dependency: user requested 'vagrant-libvirt (= 0.12.0)' ... The problem is, vagrant cache overwrites newer plugin with an older one. Let's only cache the downloaded image. Also, change the cache fingerprint script (remove "Linux"). Signed-off-by: Kir Kolyshkin <[email protected]>
kolyshkin
force-pushed
the
fix-vagrant-cache
branch
from
99fad81 to
650efb2
Compare
|
Without caching With caching, it takes 3 minutes. It still makes sense to cache the image (but not the rest). |
|
OK, it makes sense to only cache |
Times differ a lot. Last measurement -- 3 minutes w/o caching, 2:30 with cache. In any case, it makes sense to save some traffic. |
kolyshkin
force-pushed
the
fix-vagrant-cache
branch
from
988b058 to
a7de200
Compare
kolyshkin
added
the
backport/1.1-todo
AkihiroSuda
reviewed
May 24, 2023
eiffel-fl
reviewed
May 25, 2023
5 tasks
... so we can run all four jobs in parallel. While at it, fix the comment in the file. Signed-off-by: Kir Kolyshkin <[email protected]>
kolyshkin
force-pushed
the
fix-vagrant-cache
branch
from
a7de200 to
bb4dbbc
Compare
|
@thaJeztah PTAL |
AkihiroSuda
approved these changes
Jun 6, 2023
kolyshkin
added
backport/1.1-done
|
backported to 1.1 in #3878 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of today, vagrant stopped working, my best guess is due to bad caching. Here's an excerpt from logs (https://cirrus-ci.com/task/6211443486359552?logs=vagrant#L59):
Note the vargrant-libvirt version difference (0.12.1 installed, 0.12.0 shown in
vagrant uperror). I think the installed version gets overwritten by an older one from the cache.To fix, let's only cache
~/.vagrant.d/boxes(to save traffic downloading fedora image).