-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go.mod: runtime-spec v1.1.0-rc.2 #3830
Conversation
bfa9978
to
b0933ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
b0933ec
to
fca5b4c
Compare
rebased |
@thaJeztah @cyphar PTAL |
docs/spec-conformance.md
Outdated
v1.1.0-rc.2 | time namespaces | TODO | ||
v1.1.0-rc.2 | rsvd hugetlb cgroup | TODO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we create tracking tickets for these (if there's none yet)? and link to those (after TODO)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
fca5b4c
to
16a7087
Compare
See https://github.com/opencontainers/runtime-spec/releases/tag/v1.1.0-rc.2 for the spec changes. The `runc features` json is now defined in https://github.com/opencontainers/runtime-spec/blob/v1.1.0-rc.2/specs-go/features/features.go Replaces PR 3829 Signed-off-by: Akihiro Suda <[email protected]>
16a7087
to
6beb3c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
See https://github.com/opencontainers/runtime-spec/releases/tag/v1.1.0-rc.2 for the spec changes.
The
runc features
json is now defined inhttps://github.com/opencontainers/runtime-spec/blob/v1.1.0-rc.2/specs-go/features/features.go
Replaces PR #3829