-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.0]: ci: add go 1.17, drop go 1.15 #3299
Conversation
b84f51c
to
857abc5
Compare
Weird; the CI failure should be fixed by commit fdee865. Ahh, somehow I managed to use very old release-1.0 branch. Should be fixed now. |
@@ -18,7 +18,7 @@ jobs: | |||
fail-fast: false | |||
matrix: | |||
# Docker/Moby still builds runc with Go 1.13, so we should still support Go 1.13. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now we can drop 1.13
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know Moby moved on, but I'm not sure about everybody else.
This is a maintenance branch, perhaps it makes sense to keep 1.13 compatibility since the cost is zero (unless we'll want to backport something massive) and it might save someone a big headache.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, the comment is no longer "correct", but it I guess it's fine to keep the 1.13
version in the test-matrix for now (it's just a single word).
I have removed go 1.15 tests as required for release-1.0 branch. TODO: add go 1.17 tests as required once this is merged. |
857abc5
to
83ec813
Compare
Add Go 1.17, grop 1.15 from CI; since 1.17 release 1.15 is unsupported. Keep 1.13 in 1.0 branch, since an older version of Docker/Moby might use it. Keep 1.16 in Dockerfile, since this is a stable branch and we'd rather not swap horses in the middle of the stream. This corresponds to commit a587180 in main branch. Signed-off-by: Kir Kolyshkin <[email protected]>
83ec813
to
e73ff66
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is the same as #3021 but for release-1.0.
Add Go 1.17, grop 1.15 from CI; since 1.17 release 1.15 is unsupported.
Keep 1.13 in 1.0 branch, since an older version of Docker/Moby might use it.
Keep 1.16 in Dockerfile, since this is a stable branch.