-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix conversion of sysctl variable dots and slashes #3257
Fix conversion of sysctl variable dots and slashes #3257
Conversation
2818710
to
5f5a55d
Compare
PTAL @AkihiroSuda @mrunalp |
5f5a55d
to
80e8284
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some nits.
Can you please separate out the package validate_test -> package validate
change to a separate (first) commit?
80e8284
to
f317f87
Compare
LGTM except for a single nit, thank you @mengjiao-liu! Also, this needs to be rebased due to #3261 |
Ah, and the signed-off-by needs to be added to the commits (see https://github.com/opencontainers/runc/pull/3257/checks?check_run_id=4100751081) |
f317f87
to
d6ddce7
Compare
Signed-off-by: Mengjiao Liu <[email protected]>
Signed-off-by: Mengjiao Liu <[email protected]>
d6ddce7
to
a9bb11e
Compare
Rebased and signed-off-by. Thanks for reminding! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Ref #3256
see
sysctl conversion function according to the linux sysctl conversion definition.
see following webpages for more details:
https://man7.org/linux/man-pages/man8/sysctl.8.html
https://man7.org/linux/man-pages/man5/sysctl.d.5.html
Related to: