Add support for seccomp actions ActKillThread and ActKillProcess
#2564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saschagrunert
changed the title
ActKillThread and ActKillProcessActKillThread and ActKillProcess
|
Removing the WIP since it looks like we do not get a new release of seccomp/libseccomp-golang soon. |
AkihiroSuda
previously approved these changes
Aug 21, 2020
kolyshkin
reviewed
Aug 25, 2020
saschagrunert
force-pushed
the
kill-thread-process
branch
from
428a931 to
43eec87
Compare
AkihiroSuda
previously approved these changes
Aug 28, 2020
|
Needs a rebase and probably a small rework given #2750. |
saschagrunert
force-pushed
the
kill-thread-process
branch
from
43eec87 to
333f7a5
Compare
|
Rebased on top of the latest master branch. |
saschagrunert
force-pushed
the
kill-thread-process
branch
from
333f7a5 to
7a284c4
Compare
|
Needs rebase |
saschagrunert
force-pushed
the
kill-thread-process
branch
3 times, most recently
from
9a9418e to
bd5ee6c
Compare
|
Rebased on top of the latest |
AkihiroSuda
reviewed
May 6, 2021
AkihiroSuda
previously approved these changes
May 6, 2021
saschagrunert
force-pushed
the
kill-thread-process
branch
from
bd5ee6c to
1ba567d
Compare
AkihiroSuda
previously approved these changes
May 6, 2021
|
Sorry needs rebase |
saschagrunert
force-pushed
the
kill-thread-process
branch
3 times, most recently
from
1d9fdf1 to
cf51093
Compare
Rebased on top of the latest master branch. |
|
Commit seems broken |
saschagrunert
force-pushed
the
kill-thread-process
branch
from
cf51093 to
17adfff
Compare
Two new seccomp actions have been added to the libseccomp-golang dependency, which can be now supported by runc, too. ActKillThread kills the thread that violated the rule. It is the same as ActKill. All other threads from the same thread group will continue to execute. ActKillProcess kills the process that violated the rule. All threads in the thread group are also terminated. This action is only usable when libseccomp API level 3 or higher is supported. Signed-off-by: Sascha Grunert <[email protected]>
saschagrunert
force-pushed
the
kill-thread-process
branch
from
17adfff to
4aee5e3
Compare
AkihiroSuda
approved these changes
Jul 28, 2021
|
#2682 is merged, @saschagrunert can you please rebase? |
|
Given how small the change is, I'll just carry this. I'm sure Sascha won't mind. 😉 |
|
Carried in #3204. |
|
Thanks y'all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two new seccomp actions have been added to the libseccomp-golang
dependency, which can be now supported by runc, too.
ActKillThread kills the thread that violated the rule. It is the same as
ActKill. All other threads from the same thread group will continue to
execute.
ActKillProcess kills the process that violated the rule. All threads in
the thread group are also terminated. This action is only usable when
libseccomp API level 3 or higher is supported.
Xref for requesting a new release in libseccomp-golang: seccomp/libseccomp-golang#55