Added conversion for cpu.weight v2 #2213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
AkihiroSuda
approved these changes
Jan 17, 2020
|
LGTM |
hqhq
reviewed
Feb 1, 2020
Zyqsempai
force-pushed
the
2166-convert-cpu-weight-poperly
branch
from
2567240 to
1febadd
Compare
|
@hqhq Done, PTAL |
hqhq
reviewed
Feb 11, 2020
Zyqsempai
force-pushed
the
2166-convert-cpu-weight-poperly
branch
2 times, most recently
from
5d3a4e0 to
fdd4fd1
Compare
|
@hqhq PTAL on more time here as well. |
hqhq
reviewed
Feb 12, 2020
Zyqsempai
force-pushed
the
2166-convert-cpu-weight-poperly
branch
from
fdd4fd1 to
7c439cc
Compare
Signed-off-by: Boris Popovschi <[email protected]>
|
LGTM |
|
merge? |
|
Needs re-approve. @mrunalp |
|
LGTM |
AkihiroSuda
added a commit
to AkihiroSuda/runc
that referenced
this pull request
Mar 9, 2020
* TestConvertCPUSharesToCgroupV2Value(0) was returning 70369281052672, while the correct value is 0 * ConvertBlkIOToCgroupV2Value(0) was returning 32, while the correct value is 0 * ConvertBlkIOToCgroupV2Value(1000) was returning 4, while the correct value is 10000 Fix opencontainers#2244 Follow-up to opencontainers#2212 opencontainers#2213 Signed-off-by: Akihiro Suda <[email protected]>
AkihiroSuda
added a commit
to AkihiroSuda/runc
that referenced
this pull request
Mar 12, 2020
* TestConvertCPUSharesToCgroupV2Value(0) was returning 70369281052672, while the correct value is 0 * ConvertBlkIOToCgroupV2Value(0) was returning 32, while the correct value is 0 * ConvertBlkIOToCgroupV2Value(1000) was returning 4, while the correct value is 10000 Fix opencontainers#2244 Follow-up to opencontainers#2212 opencontainers#2213 Signed-off-by: Akihiro Suda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2166
Added conversion for cpu.weight v2 from cpu.shares
Signed-off-by: Boris Popovschi [email protected]