rootless: remove CgroupsPath #1691
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Akihiro Suda <[email protected]>
|
Hmm, it looks CgroupsPath should be removed only if the user lacks permission: https://github.com/opencontainers/runc/pull/1540/files I'll update PR |
|
Yeh we did #1540 which allows rootless containers to use cgroups if the cgroup hierarchy is correctly set up for owner and permissions (this is how we do rootless containers in Garden) |
|
Hmm, #1657 (ignore permission err) seems the simplest solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Akihiro Suda [email protected]
ref: containerd/containerd#2006