Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check the error return from StopUnit() in UnifiedManager#Destroy() #2309

Closed
tedyu opened this issue Apr 12, 2020 · 1 comment
Closed

Check the error return from StopUnit() in UnifiedManager#Destroy() #2309

tedyu opened this issue Apr 12, 2020 · 1 comment
Labels
area/systemd

Comments

@tedyu
Copy link
Contributor

tedyu commented Apr 12, 2020

Currently the error return from StopUnit() is ignored.

	dbusConnection.StopUnit(getUnitName(m.Cgroups), "replace", nil)

We should check the error return.
kolyshkin added a commit that referenced this issue Apr 28, 2020
@kolyshkin
Merge pull request #2331 from lifubang/StartTransientUnit
0a4dcc0 
check that StartTransientUnit/StopUnit succeeds

LGTMs: @AkihiroSuda @kolyshkin 
Closes #2313, #2309
@kolyshkin kolyshkin mentioned this issue Apr 28, 2020
Closed
@kolyshkin
Copy link
Contributor

Fixed by #2331

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/systemd
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tedyu @kolyshkin