Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blog: Add "OCI Runtime Spec v1.1" #133

Merged
merged 1 commit into from
Jul 21, 2023
Merged

blog: Add "OCI Runtime Spec v1.1" #133

merged 1 commit into from
Jul 21, 2023

Conversation

AkihiroSuda
Copy link
Member

@AkihiroSuda AkihiroSuda commented Jul 18, 2023 •
edited
Loading

Let me merge the spec v1.1 PR and this blog PR simultaneously.
(ETA: 2023-07-20)

@AkihiroSuda
Copy link
Member Author

cc @opencontainers/runtime-spec-maintainers @caniszczyk @amye
Whose LGTMs are needed for merging blog PRs?

@AkihiroSuda AkihiroSuda mentioned this pull request Jul 18, 2023
Merged
12 tasks
@AkihiroSuda AkihiroSuda force-pushed the runtime-spec-v1.1.0 branch 2 times, most recently from f0f8d07 to 3212194 Compare July 19, 2023 14:14
@AkihiroSuda AkihiroSuda force-pushed the runtime-spec-v1.1.0 branch from f24cf4f to 404c2ce Compare July 19, 2023 16:01
@AkihiroSuda
Copy link
Member Author

@cyphar Thanks, applied your suggestions

cyphar
cyphar reviewed Jul 21, 2023
View reviewed changes
content/posts/blog/2023-07-20-oci-runtime-spec-v1-1.md Outdated

Note that the `CLOCK_REALTIME` clock (the best known Linux clock) is not isolated with time namespaces.

runc doesn't implement time namespaces yet, but there is a [pull request](https://github.com/opencontainers/runc/pull/3876) to implement it.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR completely slipped my mind. I'll work on getting this merged and we can update the blog post after it's merged. Not a blocker for publishing of course.

cyphar
cyphar approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@cyphar cyphar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

In the past I think we usually wanted to get approval from @caniszczyk or @amye before posting something to the OCI website. There isn't an official maintainer list (since I worked on the site in the past, I have merge rights but I suspect I'm not supposed to use them?).

@AkihiroSuda @cyphar
blog: Add "OCI Runtime Spec v1.1"
2707bd2 
Co-authored-by: Aleksa Sarai <[email protected]>
Signed-off-by: Akihiro Suda <[email protected]>
@AkihiroSuda AkihiroSuda force-pushed the runtime-spec-v1.1.0 branch from 404c2ce to 2707bd2 Compare July 21, 2023 12:53
@AkihiroSuda
Copy link
Member Author

Changed the date to 2023-07-21

@AkihiroSuda
Copy link
Member Author

Looks like spec maintainers can just merge blog PRs by themselves now?

@jdolitsky jdolitsky merged commit ec2e589 into opencontainers:main Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianon tianon tianon approved these changes

@cyphar cyphar cyphar approved these changes

@utam0k utam0k utam0k approved these changes

@caniszczyk caniszczyk Awaiting requested review from caniszczyk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AkihiroSuda @tianon @cyphar @utam0k @jdolitsky