Validate oci-layout version #50
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wking
reviewed
Oct 25, 2016
| @@ -49,6 +58,9 @@ var validRefMediaTypes = []string{ | |||
| } | |||
|
|
|||
| func validate(w walker, refs []string, out *log.Logger) error { | |||
| if err := validatImageLayout(w); err != nil { | |||
There was a problem hiding this comment.
validatImageLayout → validateImageLayout.
coolljt0725
force-pushed
the
layout
branch
2 times, most recently
from
8c1e6e0 to
25edff2
Compare
OCI image specification has required that
`"oci-layout" MUST contain a JSON object with a version field {"imageLayoutVersion": "1.0.0"}`,
the image tool should follow this rule.
Signed-off-by: Lei Jitang <[email protected]>
|
I'm +1, but |
|
wait for opencontainers/image-spec#519 and then rebase |
Merged
|
close by #84 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OCI image specification has required that
"oci-layout" MUST contain a JSON object with a version field {"imageLayoutVersion": "1.0.0"},the image tool should follow this rule.
Signed-off-by: Lei Jitang [email protected]