tiny fix: format code and tfix #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
need rebase. |
|
rebased, PTAL |
|
LGTM |
|
LGTM |
|
@caniszczyk Can you help me with the permissions problem? Thanks. |
jonboulle
reviewed
May 24, 2017
image/manifest_test.go
Outdated
| @@ -225,6 +229,6 @@ func TestUnpackLayerRemovePartialyUnpackedFile(t *testing.T) { | |||
| t.Fatal(err) | |||
| } | |||
| if err == nil { | |||
| t.Fatal("Execpt partialy unpacked file has been removed") | |||
| t.Fatal("Execpt partially unpacked file has been removed") | |||
ping @caniszczyk. |
|
@q384566678 try again, looks like PullApprove didn't pickup the latest version of its config so I refreshed things |
|
LGTM |
|
@caniszczyk All right, thanks. |
Signed-off-by: Ma Shimiao <[email protected]>
|
Rebased, PTAL |
|
LGTM |
1 similar comment
|
LGTM |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ma Shimiao [email protected]