Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump from Go 1.16 to 1.17 #951

Merged
merged 2 commits into from
Sep 13, 2022
Merged

Conversation

sudo-bmitch
Copy link
Contributor

With Go releasing 1.19, the current supported versions are 1.18 and 1.19. I think we are staying 1 version behind supported, so this bumps to 1.17 with tests on 1.18 and 1.19. It also bumps up the GHA steps to the current versions.

Signed-off-by: Brandon Mitchell [email protected]

Signed-off-by: Brandon Mitchell <[email protected]>
@sudo-bmitch
Copy link
Contributor Author

This should also fix the CI failure on #950.

Copy link
Contributor

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@sajayantony sajayantony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that this will require a version bump on consumers, but we did discuss this earlier LGTM.

Would be good to maybe codify this in the FAQ in a package versioning section.

/cc @vbatts @stevvooe

@vbatts vbatts merged commit decdb15 into opencontainers:main Sep 13, 2022
@sudo-bmitch sudo-bmitch deleted the pr-go-1.17 branch September 13, 2022 13:47
@sudo-bmitch sudo-bmitch restored the pr-go-1.17 branch September 13, 2022 23:21
@sudo-bmitch sudo-bmitch deleted the pr-go-1.17 branch September 13, 2022 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants