Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Brandon as maintainer #909

Merged
merged 4 commits into from
Aug 10, 2022
Merged

Add Brandon as maintainer #909

merged 4 commits into from
Aug 10, 2022

Conversation

jdolitsky
Copy link
Member

@jdolitsky jdolitsky commented Apr 29, 2022

Nomination for a New Maintainer

Nominating Maintainer

jdolitsky

New Maintainer

sudo-bmitch

Justification

  • Attendance in OCI weekly meetings
  • Activity in image-spec/distribution-spec issues relating to extending specs
  • Contributing to the OCI Reference Types working group
  • Overall solid person

Need 3 approvals from the current 5 maintainers:

@dlorenc
Copy link

dlorenc commented Apr 29, 2022

Strong +1!

@sudo-bmitch
Copy link
Contributor

Thank you @jdolitsky! I'd be happy to accept this if approved by the maintainers.

@vbatts
Copy link
Member

vbatts commented Apr 29, 2022 via email

jonjohnsonjr
jonjohnsonjr previously approved these changes Apr 29, 2022
@jonjohnsonjr
Copy link
Contributor

LGTM

@sajayantony
Copy link
Member

+1.

@jdolitsky
Copy link
Member Author

something happened w/ DCO stuff, did not intend to "dismiss stale reviews"

@jdolitsky
Copy link
Member Author

For CI failure, see #916

@vbatts
Copy link
Member

vbatts commented May 12, 2022

rebase pls

@jdolitsky
Copy link
Member Author

I've updated the issue description to follow the new template

@estesp
Copy link
Contributor

estesp commented Jul 29, 2022

@stevvooe @cyphar @jonboulle would be great to get votes up or down on this candidate for maintainer. If we have maintainers who feel they can't vote then it would be great to understand what additional information would be helpful to make a decision. Thanks!

@jdolitsky
Copy link
Member Author

ping

Copy link
Member

@vbatts vbatts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💚

@jdolitsky
Copy link
Member Author

Thanks all. I think this is good to merge

@jdolitsky
Copy link
Member Author

pingity ping pong ping ping

@vbatts
Copy link
Member

vbatts commented Aug 9, 2022

just went over the governance again, and not recalling whether there is special procedure for bringing on maintainers.
(whether it's 2 LGTMs; simple majority; or 2/3 majority)
ping @caniszczyk @amye

@tianon
Copy link
Member

tianon commented Aug 9, 2022

See opencontainers/runtime-spec#1150 (comment) for a semi-recent analysis of that from the perspective of the runtime-spec repository (I'm guessing the image-spec repo is in a similar place and likely has a very similar repo governance doc).

@vbatts
Copy link
Member

vbatts commented Aug 9, 2022

@tianon thanks for that.

@vbatts
Copy link
Member

vbatts commented Aug 10, 2022

As this has 2/3 quorum of current maintainers (and has been opened for at least five days), this is a go!

Welcome @sudo-bmitch !

@vbatts vbatts merged commit 2014771 into opencontainers:main Aug 10, 2022
@vbatts vbatts mentioned this pull request Aug 10, 2022
5 tasks
@vbatts
Copy link
Member

vbatts commented Aug 10, 2022

@jonboulle
Copy link
Contributor

lgtm! thanks brandon for your contributions over the years.

@cyphar
Copy link
Member

cyphar commented Aug 11, 2022

FWIW, LGTM. I'm on vacation so didn't see the previous pings. Thanks for joining us Brandon!

@caniszczyk
Copy link
Contributor

caniszczyk commented Oct 11, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.