-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Brandon as maintainer #909
Conversation
Strong +1! |
Thank you @jdolitsky! I'd be happy to accept this if approved by the maintainers. |
LGTM
|
LGTM |
+1. |
Signed-off-by: Josh Dolitsky <[email protected]>
Signed-off-by: Josh Dolitsky <[email protected]>
Signed-off-by: Josh Dolitsky <[email protected]>
something happened w/ DCO stuff, did not intend to "dismiss stale reviews" |
For CI failure, see #916 |
rebase pls |
I've updated the issue description to follow the new template |
@stevvooe @cyphar @jonboulle would be great to get votes up or down on this candidate for maintainer. If we have maintainers who feel they can't vote then it would be great to understand what additional information would be helpful to make a decision. Thanks! |
ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💚
Thanks all. I think this is good to merge |
pingity ping pong ping ping |
just went over the governance again, and not recalling whether there is special procedure for bringing on maintainers. |
See opencontainers/runtime-spec#1150 (comment) for a semi-recent analysis of that from the perspective of the runtime-spec repository (I'm guessing the image-spec repo is in a similar place and likely has a very similar repo governance doc). |
@tianon thanks for that. |
As this has 2/3 quorum of current maintainers (and has been opened for at least five days), this is a go! Welcome @sudo-bmitch ! |
lgtm! thanks brandon for your contributions over the years. |
FWIW, LGTM. I'm on vacation so didn't see the previous pings. Thanks for joining us Brandon! |
done, thank you!
…On Wed, Aug 10, 2022 at 6:01 AM Vincent Batts ***@***.***> wrote:
@caniszczyk <https://github.com/caniszczyk> or @amye
<https://github.com/amye> might you add @sudo-bmitch
<https://github.com/sudo-bmitch> to
https://github.com/orgs/opencontainers/teams/image-spec-maintainers/members
?
—
Reply to this email directly, view it on GitHub
<#909 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAPSIIDRPZDFYSBQ4CS25TVYOD2JANCNFSM5UV6YTVQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Cheers,
Chris Aniszczyk
https://aniszczyk.org
|
Nomination for a New Maintainer
Nominating Maintainer
jdolitsky
New Maintainer
sudo-bmitch
Justification
Need 3 approvals from the current 5 maintainers: