Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

github: bring forward the versions of golang tested/built with #879

Merged
merged 2 commits into from
Dec 2, 2021
Merged

github: bring forward the versions of golang tested/built with #879

merged 2 commits into from
Dec 2, 2021

Conversation

vbatts
Copy link
Member

@vbatts vbatts commented Nov 24, 2021 •
edited
Loading

the tool dep on github.com/mjibson/esc was failing on:

# golang.org/x/tools/internal/typeparams
../../../golang.org/x/tools/internal/typeparams/normalize.go:138:17: u.EmbeddedType undefined (type *types.Interface has no field or method EmbeddedType)

stevvooe
stevvooe approved these changes Dec 2, 2021
View reviewed changes
Copy link
Contributor

@stevvooe stevvooe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vbatts vbatts merged commit b52c172 into main Dec 2, 2021
@vbatts vbatts deleted the lint-fixes branch December 2, 2021 19:20
@sudo-bmitch sudo-bmitch mentioned this pull request Sep 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonjohnsonjr jonjohnsonjr jonjohnsonjr approved these changes

@stevvooe stevvooe stevvooe approved these changes

@brendandburns brendandburns Awaiting requested review from brendandburns

@cyphar cyphar Awaiting requested review from cyphar cyphar is a code owner

@jonboulle jonboulle Awaiting requested review from jonboulle

@jstarks jstarks Awaiting requested review from jstarks

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vbatts @stevvooe @jonjohnsonjr