Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the schema validation API #742

Closed
wants to merge 1 commit into from

Conversation

zhouhao3
Copy link

@zhouhao3 zhouhao3 commented Feb 27, 2018

Fix #686
In image-tools, warn is handled as follows:

if err := validate(content); err != nil {
	for _, e := range err.Warns {
			logrus.Warn(e)
	}
...
}

Signed-off-by: Zhou Hao [email protected]

@zhouhao3 zhouhao3 force-pushed the add-api branch 2 times, most recently from d6ef022 to cc3a57a Compare February 27, 2018 08:21
@zhouhao3
Copy link
Author

This is a preliminary idea, and if it works, I will continue.

I also have the idea of using logrus.warnf to handle warnings directly.
@stevvooe @vbatts @wking @xiekeyang PTAL

@vbatts
Copy link
Member

vbatts commented Dec 17, 2019

house keeping: i think this is okay, but i'm not sure who all this will break with such a change. This makes me inclined to do nothing.

@vbatts
Copy link
Member

vbatts commented Mar 4, 2020

cleaning up as there is no further conversation

@vbatts vbatts closed this Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the schema validation API
2 participants