-
Notifications
You must be signed in to change notification settings - Fork 670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove special guidance around wasm #1055
Conversation
Go is going to support a platform like `wasm/wasip1`, `wasm/wasip2`, and eventually `wasm/wasi`. We should remove the guidance that Wasm is a special case, and fallback to following Go's guidance when describing a platform. Signed-off-by: Jason Hall <[email protected]>
A noteworthy excerpt of the PR that added it:
Well, that's what happened! Let's back it out before we cut v1.1 so we're not stuck with this decision any longer than necessary. |
Scratch that, reverse it (
I'd like to solicit comments from @rumpl, who has done a lot of work on container runtimes (moby/moby engine maintainer) and WASM/WASI, since I think he's got a somewhat unique perspective with a good amount of experience in both halves of this. 🙇 ❤️ I also think #964 (comment) is worth revisiting, specifically whether we should consider using |
Thank you for pointing this out! I'll update the original comment to avoid any (more) confusion.
I think it's simplest to say "just follow Go's precedent" for as long as we can, until there's some case where Go's semantics don't support what the OCI community needs. This very nearly happened with Wasm, and I think our response to it was good. Little did I realize that Go would leap back into action and catch up and surpass us. 😆 So I think If/when in the future some incompatibility comes up where Go precedent doesn't satisfy OCI's needs, we can carve out another exemption, or say "for |
FWIW |
Go is going to support a platform like
wasip1/wasm
,wasip2/wasm
, and eventuallywasi/wasm
. We should remove the guidance that Wasm is a special case, and fallback to following Go's guidance when describing a platform.Fixes #1053
This exception was added in #964 -- see there for original (outdated!) discussion.